Repository navigation
fix: use apple_a14 CPU model for iOS simulator NEON support - #12
Conversation
Changed iOS simulator target from apple_m1 to apple_a14 to ensure NEON SIMD intrinsics work correctly for box2d physics simulation. This was discovered during PR labelle-engine#248 mobile CI work. Fixes labelle-engine#250 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PR SummaryAdjusts simulator target to ensure required ARM features are available during simulator builds.
Written by Cursor Bugbot for commit 8bfc717. This will update automatically on new commits. Configure here. |
Summary of ChangesHello @apotema, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue preventing NEON SIMD intrinsics from functioning correctly within the iOS simulator environment on Apple Silicon Macs. By updating the target CPU model for the iOS simulator from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with NEON SIMD intrinsics on the iOS simulator by changing the target CPU model from apple_m1 to apple_a14. The change is correct and well-justified in both the pull request description and the new code comment, ensuring that features required by the box2d physics library are available. The modification is properly targeted within the generateIosBuildZig function, which will affect the generated build.zig for iOS projects. While reviewing, I noticed that src/ios/build_ios.zig also defines an iOS simulator target but does not specify a cpu_model. This file is not part of the current changes, but it might be worth a separate look to ensure consistency and proper NEON support across all possible build configurations for the iOS simulator.
Point the CLI at the freshly-tagged labelle-assembler v0.6.0, which ships the full #8–#13 cluster of backend/ECS bug fixes plus the absorbed plugins and examples. Changes: - DEFAULT_ASSEMBLER_VERSION: 0.5.1 → 0.6.0 New projects scaffolded via \`labelle init\` now pin to v0.6.0 and auto-download that release binary on first generate. - build.zig.zon labelle_assembler dep: a610afd → 295021cd (the v0.6.0 tag's commit SHA). The Zig package hash happens to match the previous pin because the hash is content-hashed over the assembler's paths = {build.zig, build.zig.zon, src}, and the plugins/examples absorbs didn't touch src/. Assembler v0.6.0 fixes shipping to users: - #8 SDL portable paths (Linux/Windows/Intel Mac fixed) - #9 bgfx native window handle per platform - #10 sokol audio sample buffer leak on unload - #11 raylib audio slot recycling - #12 wgpu WAV parser integer overflow + truncation tolerance - #13 zig-ecs view zero-alloc (borrows storage slice) Plus: sokol HiDPI, Android detection via ABI, iOS build.zig 0.15 compat, sokol-zig / zbgfx / zglfw / nuklear / rlImGui / raylib-zig dep pinning. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
apple_m1toapple_a14Context
This was discovered during labelle-engine PR #248 (mobile CI work). The box2d physics library uses NEON SIMD intrinsics that require specific ARM features enabled. Using
apple_a14ensures these features are available.Related
🤖 Generated with Claude Code