Repository navigation
feat(astc): read upload capabilities from backend manifests - #428
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Resolve the pipeline.zig conflict by keeping development's split: the ASTC prepass now lives in src/cli/pipeline/generate.zig, so the PR's InvalidTextureCapabilities fatal exit and comment update move there. Claude-Session: https://claude.ai/code/session_01R2K5sJDL5Msn1uRTkybiDP
ASTC upload limits now come from the pinned backend's
backend.manifest.zon, keyed by the resolved target name. The CLI no longer contains backend names or backend-version checks insrc/astc/. The command reports whether the default came from a manifest or the conservative 4x4-only fallback.The reader validates block lists and defaults strictly, supports local and cached remote package pins, and distinguishes an older manifest from a missing package. Malformed declarations stop the build rather than allowing a stale ASTC sibling to be consumed. Existing explicit/per-atlas/default precedence and stale-sibling handling remain. An explicit backend override cannot borrow the previous backend's metadata.
The companion bgfx manifest (labelle-toolkit/labelle-bgfx#157) declares 4x4/8x8 with an 8x8 default and PNG fallback on web. The assembler's runtime PNG fallback generation is unchanged; consuming the same fallback field there remains assembler #378 scope. Older backend manifests use 4x4 until their pins are updated. The converter is removed from the agnosticism guard's migration allowlist.
Validation:
src/astc/.Release the companion backend declaration before upgrading projects that require the 8x8 default. This PR targets development and does not modify provider implementation files. The guard change removes one now-clean allowlist entry, so it may need reconciling with #422.
Closes #407.
Additional integration check: assembler 0.113.2 generated all four web atlas registrations through
pickCompressedTexture(ASTC, PNG)with this manifest. The existing web PNG fallback is preserved.All six CI jobs pass: Linux/macOS/Windows build and tests, Docker build, versions integration, and progress-feed end-to-end tests. CodeRabbit skips this development base under the repository configuration; the companion bgfx PR completed both bot reviews without findings.