Repository navigation
chore: move the vendored stb headers to vendor/stb (cli#471 X2) - #502
Conversation
Third-party code lives outside src/, so the agnostic guard stops scanning upstream comments: stb_image.h's mention of iOS/Android NEON support was the only reason it sat on the allowlist (17 entries now). The bytes are unchanged (git mv); build.zig compiles stb_image_impl.c from vendor/stb and puts that directory on the include path, and build.zig.zon ships it.
|
Warning Review limit reachedNext included review available in 16 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 99 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
User coderabbitai[bot] does not have write permissions |
2 participants
Part of #471, item X2 (D7: move stb to
vendor/, not a hash exemption).stb_image.h,stb_image_write.handstb_image_impl.cmove fromsrc/cli/tovendor/stb/withgit mv, bytes unchanged.build.zig(wireStb) now compilesvendor/stb/stb_image_impl.cand putsvendor/stbon the include path.build.zig.zonaddsvendorto.pathsso the package ships it.cli/stb_image.hwas only listed for an upstream comment about iOS/Android NEON, so it leaves the allowlist: 18 → 17 entries.Tests:
zig build testpasses 13/13 steps (1132 tests). The Windows CI builds the C file from its new path.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.