Repository navigation
feat!: remove iOS from the core; the ios target belongs to labelle-ios (cli#471 I5) - #515
Conversation
…s (cli#471 I5) The ios target is owned by labelle-toolkit/labelle-ios (v0.1.0, in the provider registry): app bundling after build, simulator launch as the run replacement, and the bundle replacement. The core keeps nothing iOS-specific: - src/cli/ios.zig is deleted, along with the `labelle ios` command, its parsing and help, and Command.ios_cmd. - Deleted: the legacy own-build branch, the forced sokol backend (no silent substitution, D5), the ios Bypass arms, legacyRunBranch, and the simulator launch branch. - `ios` is no longer a reserved provider namespace. - IosConfig/Orientation are gone. project.labelle is read with ignore_unknown_fields, so an old `.ios` block still parses and is ignored. `labelle ios ...` now gives the unknown-command diagnostic with nothing generated. `run --platform=ios` without an owning provider gives the no-provider diagnostic, or NoRunReplacement when the provider has no `replace run`. The e2e scripts and docs are updated. The agnostic guard drops five entries. BREAKING CHANGE: `labelle ios` is removed; use labelle-ios with `labelle build|run|bundle --platform=ios`. Targets for ios generate into <project backend>_ios, since the backend is no longer forced.
|
Warning Review limit reachedNext included review available in 44 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 105 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (20)
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
User coderabbitai[bot] does not have write permissions |
Part of #471, item I5. Breaking: meant for CLI 4.0 (D1). Do not merge into a 3.x release.
The
iostarget is owned by labelle-toolkit/labelle-ios v0.1.0, which is in the provider registry: an app hook after build, alaunchrun replacement for the simulator, and abundlereplacement. The core keeps nothing iOS-specific.Removed
src/cli/ios.zig(~900 lines), thelabelle ioscommand, its parsing and help, andCommand.ios_cmd.pipeline.zig, and the forced sokol backend inargs_resolve.zig(no silent substitution, D5).Bypassarms.legacyRunBranchgoes too, since it had no other users, and so does theowner_defaultparameter ofproviderBypass.run.zig, andiosas a reserved provider namespace.IosConfig/Orientation.project.labelleis read withignore_unknown_fields, so an old.iosblock still parses and is ignored. A test covers it.Behaviour
labelle ios …gives the unknown-command diagnostic, with nothing generated.labelle run --platform=ioswithout an owning provider gives the no-provider diagnostic, orNoRunReplacementwhen the provider has noreplace run.<project backend>_ios, because the backend is no longer forced.The agnostic guard drops five entries, 17 → 12. Docs point at labelle-ios, and
rfc-ios-platform.mdis kept with a "superseded" note.Tests
zig build testpasses 13/13 steps (1152 tests).test/provider_targets_e2e.py(52 invocations) andtest/provider_hooks_e2e.py(83) are rewritten to the new diagnostics and pass locally.docs/migrating-to-4.0.mdcomes with the 4.0 release, per the RFC.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.