Repository navigation
docs(rfc-i18n): device language joins the startup resolution - #892
Merged
Merged
Conversation
OS detection was a non-goal "until one game actually wants it"; flying-platform#917 does. It slots in where §8 said it would: above .default, below the player's own choice. Documents the backend seam (window.systemLocale) and the matching rules applySystemLocale uses.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Comment |
Collaborator
Author
|
FP side: https://github.com/moca-tecnologia/flying-platform-labelle/pull/936 (bumps the pins after this is released). |
apotema
approved these changes
Sep 28, 2026
apotema
left a comment
apotema
left a comment
Contributor
There was a problem hiding this comment.
LGTM. It matches the implementation in labelle-bgfx#135 and labelle-assembler#753: the resolution order, @hasDecl optionality, and the exact → language → same-language matching. Please merge it together with assembler#753, so the RFC doesn't describe behaviour that hasn't shipped yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Flying-Platform/flying-platform-labelle#917. Docs only: RFC-I18N §8 — OS language detection moves from non-goal to the startup resolution, above
.defaultand below the player's choice; documents thewindow.systemLocalebackend seam andapplySystemLocalematching rules.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.