Skip to content

feat(slides): fill xml-schema-quick-ref gaps that forced XSD fallback - #2026

Merged
R0bynZhu merged 1 commit into
mainfrom
opt-xml-schema-quick-ref
Jul 23, 2026
Merged

feat(slides): fill xml-schema-quick-ref gaps that forced XSD fallback#2026
R0bynZhu merged 1 commit into
mainfrom
opt-xml-schema-quick-ref

Conversation

@R0bynZhu

@R0bynZhu R0bynZhu commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

From EVAL-07-22-02-53 (42 convos), agents fell back to the full XSD for:

  • shape type enum + presetHandlers (rounded corners)
  • polyline (bounding-box positioning, required border, connector type)
  • table merged cells (colspan / rowspan)

Add compact coverage for each, sized to real usage (shape/polyline type lists trimmed to what actually appears in generations). Chart gaps deferred.

Summary by CodeRabbit

  • Documentation
    • Added guidance on XML shape type values and optional attributes (including handler and custom-only path behavior).
    • Expanded <polyline> documentation with rules for external-rectangle positioning, required <border> settings, and connector type defaults/choices.
    • Clarified table cell merging: use <td> colspan/rowspan, and merged/covered cells no longer define additional <td>.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 95b492d3-af72-435a-91c8-e9984dadd1ff

📥 Commits

Reviewing files that changed from the base of the PR and between c4bfc94 and 39953f3.

📒 Files selected for processing (1)
  • skills/lark-slides/references/xml-schema-quick-ref.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • skills/lark-slides/references/xml-schema-quick-ref.md

📝 Walkthrough

Walkthrough

The XML schema quick reference adds guidance for shape types and attributes, polyline positioning and connector defaults, and table-cell merging with colspan and rowspan.

Changes

XML Schema Documentation

Layer / File(s) Summary
Schema element guidance
skills/lark-slides/references/xml-schema-quick-ref.md
Adds shape type and optional attribute references, polyline positioning and connector rules, and table cell-merging instructions.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: filling slide XML schema quick-reference gaps that previously triggered XSD fallback.
Description check ✅ Passed The description covers the motivation and main changes, though the template's Test Plan and Related Issues sections are not filled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch opt-xml-schema-quick-ref

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.07%. Comparing base (67015ee) to head (39953f3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2026   +/-   ##
=======================================
  Coverage   75.06%   75.07%           
=======================================
  Files         902      902           
  Lines       95944    95950    +6     
=======================================
+ Hits        72025    72031    +6     
  Misses      18380    18380           
  Partials     5539     5539           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@39953f3e013f65412eb78aa4d6eb762a0d305071

🧩 Skill update

npx skills add larksuite/cli#opt-xml-schema-quick-ref -y -g

From EVAL-07-22-02-53 (42 convos), agents fell back to the full XSD for:
- shape type enum + presetHandlers (rounded corners)
- polyline (bounding-box positioning, required border, connector type)
- table merged cells (colspan / rowspan)

Add compact coverage for each, sized to real usage (shape/polyline type
lists trimmed to what actually appears in generations). Chart gaps deferred.
@R0bynZhu
R0bynZhu force-pushed the opt-xml-schema-quick-ref branch from c4bfc94 to 39953f3 Compare July 23, 2026 09:24
@R0bynZhu
R0bynZhu merged commit 715aa8d into main Jul 23, 2026
32 of 42 checks passed
@R0bynZhu
R0bynZhu deleted the opt-xml-schema-quick-ref branch July 23, 2026 14:18
kiraWangRuilong pushed a commit that referenced this pull request Jul 24, 2026
…#2026)

From EVAL-07-22-02-53 (42 convos), agents fell back to the full XSD for:
- shape type enum + presetHandlers (rounded corners)
- polyline (bounding-box positioning, required border, connector type)
- table merged cells (colspan / rowspan)

Add compact coverage for each, sized to real usage (shape/polyline type
lists trimmed to what actually appears in generations). Chart gaps deferred.
@liangshuo-1 liangshuo-1 mentioned this pull request Jul 24, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants