Skip to content

fix: honor recovered E2E retries - #2400

Merged
liangshuo-1 merged 1 commit into
larksuite:mainfrom
Tantanz20020918:fix/e2e-retry-report-status
Aug 19, 2026
Merged

liangshuo-1 merged 1 commit into
larksuite:mainfrom
Tantanz20020918:fix/e2e-retry-report-status

Conversation

@Tantanz20020918

@Tantanz20020918 Tantanz20020918 commented Aug 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Prevent the JUnit publishing step from marking live E2E as failed when gotestsum successfully recovers an initially failing test through its configured retries.

Changes

  • Keep gotestsum as the authority for the final live E2E result.
  • Publish the complete JUnit retry history without making recovered failures fail the report step.

Test Plan

  • Real gotestsum v1.12.3 fixture: the first attempt failed and retry 1 passed; final exit code was 0.
  • Ran the pinned dorny/test-reporter v3.0.0 against that recovered JUnit report with fail-on-error disabled; final exit code was 0.
  • Persistent-failure fixture failed initially and on both retries; final gotestsum exit code was 1.
  • make script-test (164 tests passed).

Related Issues

  • None

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 194c90be-7777-4f1e-832a-c40fbdbc83be

📥 Commits

Reviewing files that changed from the base of the PR and between 2829ecd and cd48dfc.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • scripts/ci-workflow.test.sh

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow now prevents E2E report publication errors from failing the workflow. A shell test extracts the live report step and verifies fail-on-error: false.

Changes

E2E report publishing

Layer / File(s) Summary
Non-blocking report publishing
.github/workflows/ci.yml, scripts/ci-workflow.test.sh
The CLI E2E report step sets fail-on-error: false. The CI workflow test verifies this configuration.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to cd48d

The CI workflow now preserves successful E2E results when retries recover an initially failing test, with a matching contract test; no actionable merge-blocking risk remains.

Suggested labels: domain/ccm

Suggested reviewers: yxzhaao

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the change to honor recovered E2E retries.
Description check ✅ Passed The description includes all required sections and provides clear changes, verification details, and related issue status.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@c7438c7e74e05dc97c0aff8c56889a59890ea9a0

🧩 Skill update

npx skills add Tantanz20020918/cli#fix/e2e-retry-report-status -y -g

@Tantanz20020918
Tantanz20020918 force-pushed the fix/e2e-retry-report-status branch from cd48dfc to c7438c7 Compare August 19, 2026 06:30
@github-actions github-actions Bot added size/S Low-risk docs, CI, test, or chore only changes and removed size/M Single-domain feat or fix with limited business impact labels Aug 19, 2026
@liangshuo-1
liangshuo-1 merged commit de45ec6 into larksuite:main Aug 19, 2026
21 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Low-risk docs, CI, test, or chore only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants