Repository navigation
fix(ci): repair checkpoint build validation and concurrent branch checks - #285
Merged
Merged
Conversation
Carry-Group: upstream-bugfixes Carry-Observation: Preserve exact installation ownership assertions across symlinked temporary directories.
Carry-Group: legacy-sidebar Carry-Observation: The creator evidence index is LastCode migration 12 and runs after upstream V2 upgrades. Seed historical V1 databases only through LastCode migration 11.
Carry-Group: build-ci Carry-Observation: Publication validates V1 snapshots and preview upgrades. CI permits removed branch settings only after a previously existing local ref disappears; surviving branches and orphan settings stay protected.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
lastobelus
added a commit
that referenced
this pull request
Oct 5, 2026
When a task plan is shown alongside a composer banner, its summary also appears beside the send/stop controls. The duplicate uses banner layout outside its container, so a long task title stretches across the footer and pushes controls outside the composer. Remove the stale footer insertion. The existing task summary above the composer and its expandable task list continue to provide task access in expanded, resting, and collapsed layouts. Current upstream already omits this insertion; it was retained by LastCode's resumable-actions carry group. Validation: `git diff --check` and focused formatting passed. An independent read-only review found no issues with task access, accessibility, responsive placement, or activity/primary actions. The production-component fixture reproduced two summaries and a Stop button outside the composer before the fix; afterward it showed one summary, no footer summary, and Stop inside the composer. At a narrow viewport, the controls fit without horizontal overflow and the task list opened and closed correctly. This verifies the affected banner/footer composition, not a full application run. Before/after screenshot publication is pending an authenticated browser session. The initial GitHub CI run failed on stale database-migration test expectations already corrected by #285. The branch now includes that merged fix, with the composer patch unchanged. Fresh GitHub CI and Codex review are requested for commit `7573ae645a55063db1fc2397bc135d67939c9b82`. Quick CI is intentionally skipped at the user's request. Implemented and reviewed with GPT-6.1-Sol in the Codex harness. Carry-Source-Ref: refs/lastcode/carry-sources/pr-284/7573ae645a55063db1fc2397bc135d67939c9b82 Carry-Source-Base: 05fcbc0 Carry-Source-Head: 7573ae6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkpoint package build failed because installation fixtures compared symlinked temporary paths, migration tests still treated the creator index as an upstream migration, and a historical V1 fixture ran a V2-only migration. The CI integrity guard also rejected legitimate branch renames performed in another worktree.
Resolve fixture paths before asserting installation ownership, keep creator-index expectations in the LastCode ledger, and seed the V1 snapshot through the last V1-compatible migration. Expand the installable migration gate to cover V1 initialization and preview upgrades. Allow removed branch settings only when a branch that existed at CI start has disappeared; retain protection for surviving branches, orphan settings, and changed values.
Validation:
Implemented with GPT-6.1-Sol via Codex; independently reviewed with GPT-6-Astra via Codex.