Skip to content

feat(lastcode): add thread annotations - #50

Merged
lastobelus merged 12 commits into
lastcode/mainfrom
lastcode/thread-annotations
Aug 22, 2026
Merged

lastobelus merged 12 commits into
lastcode/mainfrom
lastcode/thread-annotations

Conversation

@lastobelus

@lastobelus lastobelus commented Aug 22, 2026 •

Copy link
Copy Markdown
Owner

Threads currently have no durable place for lightweight notes, follow-ups, or completion state.

This adds one Markdown annotation per thread, with composer and legacy-sidebar entry points, a dismissible post-it above the composer, and an anchored marker in the conversation minimap. Annotation edits and resolution are persisted and synchronized without changing thread ordering, and every mutation anchors to the latest surviving user message.

Review: five Luna-high rounds covered correctness, UI/components, simplicity, UX, and repository best practices. Five findings were applied across four fixes: revert-safe reanchoring, jump-hint annotation discoverability, narrow-gutter pointer safety, and intentional empty-thread gating using a client-visible readiness signal. Two first-cut tradeoffs were defended: eager shell bodies keep sidebar hover immediate without a fetch/cache protocol, and the small anchor selectors remain local to their different state representations.

Validation: exact-head pnpm lastcode:ci:quick; 163 focused annotation/regression tests; contracts, client-runtime, web, and server typechecks; fresh isolated server startup through migration 41.

Authored with GPT-5.6 through the Codex harness.

@lastobelus
lastobelus marked this pull request as ready for review August 22, 2026 00:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55b37c0a07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/client-runtime/src/state/threadReducer.ts
Comment thread apps/web/src/components/chat/MessagesTimeline.tsx
Comment thread packages/contracts/src/orchestration.ts
@lastobelus
lastobelus force-pushed the lastcode/thread-annotations branch 2 times, most recently from 1ebf6de to 9a3b321 Compare August 22, 2026 07:15
@lastobelus

Copy link
Copy Markdown
Owner Author

@codex review

ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a3b32105f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/chat/MessagesTimeline.tsx Outdated
Comment thread apps/web/src/components/thread-annotation/ThreadAnnotation.tsx
Comment thread apps/web/src/components/LegacySidebar.tsx
@lastobelus

ghost commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9722273c07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/contracts/src/orchestration.ts
Comment thread apps/server/src/orchestration/decider.ts
Comment thread apps/web/src/components/chat/MessagesTimeline.tsx
@lastobelus
lastobelus force-pushed the lastcode/thread-annotations branch from 9722273 to 167bc88 Compare August 22, 2026 07:54
@lastobelus

ghost commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 167bc8896d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/components/LegacySidebar.tsx
@lastobelus

ghost commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

ghost commented Aug 22, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 1c462f3938

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lastobelus
lastobelus merged this pull request into lastcode/main Aug 22, 2026
@lastobelus
lastobelus deleted the lastcode/thread-annotations branch August 22, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant