Repository navigation
fix(server): lease Darwin server ownership - #57
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #39.
On macOS, the desktop client and a headless launchd service could otherwise start separate servers against the same LastCode home. Concurrent ownership risks conflicting state writers and makes the service transition unsafe.
This adds a Darwin kernel-backed exclusive lease for each server base directory. Server startup acquires the lease before constructing the runtime, reports a clear error when another owner holds it, rejects unsafe lock paths, and releases ownership with the server scope. Other platforms retain their existing startup behavior rather than gaining a weaker PID-file fallback.
Focused coverage exercises contention, release and reacquisition, canonicalized paths, symlink rejection, invalid lock paths, and the non-Darwin boundary. The rebased patch also passed server typechecking, targeted lint/format checks, and the normal four-stage LastCode quick-CI push guard.
Built with GPT-5.4 in the Codex harness.