Conversation
REL-15681: rulesets reject the release workflow's push to main, so the asset-upload step never ran. Push the version tag only, create the release as a draft, then publish. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eb2eda7. Configure here.
| run: | | ||
| if [[ -n "${GITHUB_RELEASE_TOKEN:-}" ]]; then | ||
| echo "GITHUB_TOKEN=$GITHUB_RELEASE_TOKEN" >> "$GITHUB_ENV" | ||
| fi |
There was a problem hiding this comment.
Publish aborts on unset GITHUB_TOKEN
High Severity
When GITHUB_RELEASE_TOKEN is empty, GITHUB_TOKEN is no longer exported to GITHUB_ENV. stage-artifacts.sh later expands $GITHUB_TOKEN under set -u, so the publish step dies before Docker Hub, Homebrew, or the GitHub release run.
Reviewed by Cursor Bugbot for commit eb2eda7. Configure here.
| with: | ||
| token: ${{ github.token }} | ||
| tag: v${{ inputs.releaseVersion }} | ||
| commit: ${{ env.RELEASE_COMMIT }} |
There was a problem hiding this comment.
Failed tag push cannot create release
Medium Severity
If the tag push fails, the bump commit never reaches GitHub. ncipollo/release-action cannot create a tag at RELEASE_COMMIT because the GitHub API only tags SHAs that already exist on the remote, so continue-on-error does not still produce a release.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit eb2eda7. Configure here.


Summary
HEADtomain(blocked by Bot Bouncer + PR-required rulesets). That skip is why v2.17.0 shipped with no assets (REL-15681, run 31702824366).RELEASE_COMMITafterprepare-release.shso a missing remote tag is created from the bump commit, notmain.GITHUB_TOKENwhenGITHUB_RELEASE_TOKENis empty.Test plan
./scripts/release/push-to-origin_test.sh— local bare remote: tag is pushed,origin/maindoes not move; second run skips an existing tag. This also runs on PRs ingo-tests.release.ymlon this PR. It isworkflow_dispatchonly andmake publishpushes Docker Hub + Homebrew. After merge, optionaldryRun: truedispatch still skips GitHub release/tag push by design.mainis unchanged except via a normal version-bump PR.continue-on-erroron the tag step).Made with Cursor