Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.
This repository was archived by the owner on May 30, 2024. It is now read-only.

LDClient Typescript typing does not have an on() method #65

Description

@robertmassaioli

See: https://github.com/launchdarkly/node-client/blob/master/index.d.ts#L327

According to the "Initializing the client" documentation we should be waiting for the on('ready', callback) event to fire before using the LDClient#variation method. If this is the case then the typescript typing is missing the on method.

We should just add the typings for the on method so that typescript users don't have to write code that essentially says "trust me, there is an on() function that you can use here":

(<any>ldClient).on('ready', () => {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions