Conversation
Closed
3 tasks done
j-loreaux
reviewed
May 19, 2024
j-loreaux
left a comment
j-loreaux
left a comment
Contributor
There was a problem hiding this comment.
I think we don't want StarSubset, unless you have an explicit application in mind. Also, it would be nice if the unital versions of all these were placed in a separate file.
j-loreaux
added
awaiting-author
Contributor
|
no need to include me in the copyright. |
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…unity/mathlib4 into mans0954/StarSubSemiring
mans0954
added
awaiting-review
and removed
awaiting-author
Import summaryNo significant changes to the import graph |
PR summary f3295abb61Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
j-loreaux
approved these changes
Jul 15, 2024
Contributor
|
✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
the
delegated
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
…unity/mathlib4 into mans0954/StarSubSemiring
Contributor
Author
|
bors r+ |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…#12938) Definitions and basic properties of non-unital star subsemirings Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com> Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…#12938) Definitions and basic properties of non-unital star subsemirings Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com> Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definitions and basic properties of non-unital star subsemirings
This file heavily copies
Mathlib.Algebra.Star.NonUnitalSubalgebra, so I'm happy to assign the copyright to @j-loreaux if that's the appropriate thing to do.So far I've mostly only developed what's required for #6595 - I thought I'd check that this was the right approach before going further.