Skip to content

[Merged by Bors] - fix: address shellcheck warnings in create-adaptation-pr.sh - #34286

Closed
kim-em wants to merge 3 commits into
masterfrom
fix-shellcheck-warnings
Closed

[Merged by Bors] - fix: address shellcheck warnings in create-adaptation-pr.sh#34286
kim-em wants to merge 3 commits into
masterfrom
fix-shellcheck-warnings

Conversation

@kim-em

@kim-em kim-em commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

This PR addresses all shellcheck warnings in scripts/create-adaptation-pr.sh:

  • Quote variables to prevent globbing/word splitting (SC2086)
  • Use $(...) instead of legacy backticks (SC2006)
  • Add -r flag to read commands (SC2162)

Related PRs:

🤖 Prepared with Claude Code

This was referenced Jan 23, 2026
Merged
Merged
@github-actions

github-actions Bot commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown

PR summary 725d7a32b7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the CI Modifies the continuous integration setup or other automation label Jan 23, 2026
@kim-em @claude
fix: address shellcheck warnings in create-adaptation-pr.sh
26e34ec 
Addresses all shellcheck warnings in `scripts/create-adaptation-pr.sh`:

- Quote variables to prevent globbing/word splitting (SC2086)
- Use `$(...)` instead of legacy backticks (SC2006)
- Add `-r` flag to `read` commands (SC2162)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@kim-em
kim-em force-pushed the fix-shellcheck-warnings branch from 1062c7c to 26e34ec Compare January 23, 2026 00:38
@joneugster joneugster self-assigned this Jan 23, 2026
joneugster
joneugster approved these changes Jan 23, 2026
View reviewed changes

@joneugster joneugster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

maintainer merge

@github-actions

github-actions Bot commented Jan 23, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by joneugster.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jan 23, 2026
@adomani

adomani commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

These changes look good, thanks!

I just wonder if $BUMP_VERSION here [EDIT: it is line 143, but I don't know why the link does not work] and elsewhere should be quoted...

bors d+

@mathlib-bors

mathlib-bors Bot commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Jan 23, 2026
@kim-em

kim-em commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

Good catch! You're right that I should quote all the variables for consistency. I'll push an update to fix all remaining shellcheck warnings.

kim-em and others added 2 commits January 27, 2026 10:58
@kim-em @claude
fix: quote all remaining variables in create-adaptation-pr.sh
a9c965a 
Per shellcheck SC2086 warnings, quote all variable references to prevent
globbing and word splitting. This addresses the remaining warnings that
were missed in the initial shellcheck cleanup.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@kim-em
fix: restore executable mode on create-adaptation-pr.sh
7e9dffc
@kim-em

kim-em commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

All shellcheck warnings have been addressed. The script now passes shellcheck with no errors.

@kim-em

kim-em commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Jan 27, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jan 27, 2026
@kim-em
fix: address shellcheck warnings in create-adaptation-pr.sh (#34286)
074a92d 
This PR addresses all shellcheck warnings in `scripts/create-adaptation-pr.sh`:

- Quote variables to prevent globbing/word splitting ([SC2086](https://www.shellcheck.net/wiki/SC2086))
- Use `$(...)` instead of legacy backticks ([SC2006](https://www.shellcheck.net/wiki/SC2006))
- Add `-r` flag to `read` commands ([SC2162](https://www.shellcheck.net/wiki/SC2162))

**Related PRs:**
- leanprover/cslib#203 (cslib)
- leanprover-community/batteries#1624 (batteries)

🤖 Prepared with Claude Code
@mathlib-bors

mathlib-bors Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title fix: address shellcheck warnings in create-adaptation-pr.sh [Merged by Bors] - fix: address shellcheck warnings in create-adaptation-pr.sh Jan 27, 2026
@mathlib-bors mathlib-bors Bot closed this Jan 27, 2026
@mathlib-bors
mathlib-bors Bot deleted the fix-shellcheck-warnings branch January 27, 2026 00:34
@adomani

adomani commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Good catch! You're right that I should quote all the variables for consistency. I'll push an update to fix all remaining shellcheck warnings.

My pleasure Clau... Kim!

YellPika pushed a commit to YellPika/mathlib4 that referenced this pull request Feb 3, 2026
@kim-em @YellPika
fix: address shellcheck warnings in create-adaptation-pr.sh (leanprov…
054224d 
…er-community#34286)

This PR addresses all shellcheck warnings in `scripts/create-adaptation-pr.sh`:

- Quote variables to prevent globbing/word splitting ([SC2086](https://www.shellcheck.net/wiki/SC2086))
- Use `$(...)` instead of legacy backticks ([SC2006](https://www.shellcheck.net/wiki/SC2006))
- Add `-r` flag to `read` commands ([SC2162](https://www.shellcheck.net/wiki/SC2162))

**Related PRs:**
- leanprover/cslib#203 (cslib)
- leanprover-community/batteries#1624 (batteries)

🤖 Prepared with Claude Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joneugster joneugster joneugster approved these changes

Assignees

@joneugster joneugster

Labels

CI Modifies the continuous integration setup or other automation delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kim-em @adomani @joneugster