feat: query complexity model for algorithms theory - #372
Open
Shreyas4991 wants to merge 54 commits into
Open
Conversation
Shreyas4991
force-pushed
the
query-final-squash
branch
from
February 26, 2026 05:29
e54ec5f to
8be8d07
Compare
chenson2018
requested changes
Feb 26, 2026
chenson2018
left a comment
chenson2018
left a comment
Collaborator
There was a problem hiding this comment.
This looks in much better shape now, just some relatively minor things from me:
Contributor
Author
@chenson2018 : I think I have addressed all your review comments so far. |
chenson2018
approved these changes
Feb 27, 2026
chenson2018
left a comment
chenson2018
left a comment
Collaborator
There was a problem hiding this comment.
I pushed one small golf, and my other comments have been addressed. I left the two comments where I'd tagged @eric-wieser unresolved so they can be double checked. As usual, leaving for @fmontesi for final consideration.
eric-wieser
reviewed
Feb 27, 2026
eric-wieser
reviewed
Feb 27, 2026
eric-wieser
reviewed
Feb 27, 2026
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…o query-final-squash
Arleee1
reviewed
Mar 17, 2026
| # Query Type for Comparison Search in Lists | ||
|
|
||
| In this file we define two query types `SortOps` which is suitable for insertion sort, and | ||
| `SortOps`for comparison based searching in Lists. We define a model `sortModel` for `SortOps` |
Contributor
There was a problem hiding this comment.
Nit: Is one of the SortOps supposed to be different, or are they supposed to be duplicated?
Contributor
Author
There was a problem hiding this comment.
We changed the name to the shorter SortOps since we would like that to be the default comparison sort model
…o query-final-squash
This was referenced Mar 19, 2026
Arleee1
reviewed
Apr 16, 2026
Co-authored-by: Ethan Ermovick <61568556+Arleee1@users.noreply.github.com>
kim-em
added a commit
to kim-em/cslib
that referenced
this pull request
Apr 22, 2026
This merge preserves the commit history of leanprover#372 — Shreyas' earlier work on the query complexity model — in the ancestry of this branch. The tree is taken from upstream/main: the superseding implementation lands in the commits that follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a highly squashed version of #275 with a smaller commit an comment history for ease of further reviewing.
Authors: Shreyas Srinivas, Tanner Duve, Eric Wieser.