chore: make trivial definitions unfold - #525
Merged
Merged
Conversation
This changes function like `toStateM` to be `abbrev`s since they are only a shorthand for `liftM stateInterp`. It also marks `stateInterp` and similar as `@[simp]`, since we want these to reduce when applied to a concrete query.
This was referenced Apr 28, 2026
chenson2018
approved these changes
Apr 30, 2026
This was referenced May 1, 2026
quangvdao
pushed a commit
to quangvdao/cslib
that referenced
this pull request
May 28, 2026
This declares `liftBind` an implementation detail, encouraging users to work with `lift` and `bind` separately instead. In particular: * `>>=` is now the simp-normal form of `FreeM.bind` * `<$>` is now the simp-normal form of `FreeM.map` * `Pure.pure` is now the simp-normal form of `FreeM.pure` Note that due to a failing in the design of monads in Lean around universes, it is not always possible to use the notation. The advantage of using it when it _is_ available is that standard lemmas about lawful monads can apply. --- Depends on: * leanprover#439 * leanprover#490 * leanprover#525
benbrastmckie
pushed a commit
to benbrastmckie/cslib
that referenced
this pull request
Jun 14, 2026
This changes function like `toStateM` to be `abbrev`s since they are only a shorthand for `liftM stateInterp`. It also marks `stateInterp` and similar as `@[simp]`, since we want these to reduce when applied to a concrete query. This also fixes `contInterp` to include the missing cast functions, so that the `simp` equation lemma is not ill-formed. Split from leanprover#417, to minimize distractions from the actual change in that PR.
benbrastmckie
pushed a commit
to benbrastmckie/cslib
that referenced
this pull request
Jun 14, 2026
This declares `liftBind` an implementation detail, encouraging users to work with `lift` and `bind` separately instead. In particular: * `>>=` is now the simp-normal form of `FreeM.bind` * `<$>` is now the simp-normal form of `FreeM.map` * `Pure.pure` is now the simp-normal form of `FreeM.pure` Note that due to a failing in the design of monads in Lean around universes, it is not always possible to use the notation. The advantage of using it when it _is_ available is that standard lemmas about lawful monads can apply. --- Depends on: * leanprover#439 * leanprover#490 * leanprover#525
benbrastmckie
added a commit
to benbrastmckie/cslib
that referenced
this pull request
Jul 18, 2026
Spawned leanprover#524 (new KB5-specific full-cluster propagation rule + soundness) and leanprover#525 (KB5 completeness proof + Decidable (kb5Valid), depends on 524). Parent leanprover#515 now [BLOCKED] on 524, 525. Session: sess_1784327380_e6aeac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes function like
toStateMto beabbrevs since they are only a shorthand forliftM stateInterp. It also marksstateInterpand similar as@[simp], since we want these to reduce when applied to a concrete query.This also fixes
contInterpto include the missing cast functions, so that thesimpequation lemma is not ill-formed.Split from #417, to minimize distractions from the actual change in that PR.