fix(Foundations): add noWs guard to well-formed postfix notation - #675
Merged
chenson2018 merged 3 commits intoJul 13, 2026
Merged
Conversation
Collaborator
|
Could you please add a test in |
Contributor
Author
|
Added the regression test in |
VitaliPath
force-pushed
the
fix/well-formed-notation-collision
branch
from
June 22, 2026 22:50
7c59e3e to
c045387
Compare
Contributor
Author
|
Added the |
VitaliPath
force-pushed
the
fix/well-formed-notation-collision
branch
from
June 22, 2026 22:58
c045387 to
c9b0b48
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 5, 2026
VitaliPath
force-pushed
the
fix/well-formed-notation-collision
branch
from
July 5, 2026 17:43
c9b0b48 to
6b01f2b
Compare
Contributor
Author
|
Hey @chenson2018, I just rebased to resolve the import conflict. The history is clean, and the CI checks are green again. Ready for the merge queue whenever you have a moment |
chenson2018
approved these changes
Jul 13, 2026
chenson2018
enabled auto-merge
July 13, 2026 22:36
intgrah
pushed a commit
to intgrah/cslib
that referenced
this pull request
Jul 14, 2026
…nprover#675) Addresses leanprover#638. Converts the global well-formed notation to a macro with a `noWs` whitespace guard. This explicitly prevents the postfix parser from greedily consuming the `✓` token across line breaks, resolving the syntax collision with TimeM's prefix tick notation when both modules are imported simultaneously. --------- Co-authored-by: Sean Stoneburner <litholight@gmail.com> Co-authored-by: Chris Henson <chrishenson.net@gmail.com>
fmontesi
pushed a commit
that referenced
this pull request
Jul 22, 2026
Addresses #638. Converts the global well-formed notation to a macro with a `noWs` whitespace guard. This explicitly prevents the postfix parser from greedily consuming the `✓` token across line breaks, resolving the syntax collision with TimeM's prefix tick notation when both modules are imported simultaneously. --------- Co-authored-by: Sean Stoneburner <litholight@gmail.com> Co-authored-by: Chris Henson <chrishenson.net@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #638. Converts the global well-formed notation to a macro with a
noWswhitespace guard. This explicitly prevents the postfix parser from greedily consuming the✓token across line breaks, resolving the syntax collision with TimeM's prefix tick notation when both modules are imported simultaneously.