Skip to content

chore: update bench suite - #707

Merged
chenson2018 merged 2 commits into
leanprover:mainfrom
Garmelon:update-bench-suite
Jul 11, 2026
Merged

chore: update bench suite#707
chenson2018 merged 2 commits into
leanprover:mainfrom
Garmelon:update-bench-suite

Conversation

@Garmelon

@Garmelon Garmelon commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR refactors the cslib bench suite so it closely resembles mathlib's again, following leanprover-community/mathlib4#41587.

@Garmelon

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Jul 10, 2026

Copy link
Copy Markdown

Benchmark results for 33092f7 against c0120dd are in. There are significant results. @Garmelon

Warning

These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.

  • Bench repo commit hashes for run main differ between commits.
  • 🟥 build//instructions: +36.7T (+1835.31%)

Large changes (1🟥)

1 hidden

@Garmelon
Garmelon force-pushed the update-bench-suite branch from 33092f7 to d42966b Compare July 10, 2026 16:06
@Garmelon

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Jul 10, 2026

Copy link
Copy Markdown

Benchmark results for d42966b against c0120dd are in. There are significant results. @Garmelon

Warning

These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.

  • Bench repo commit hashes for run main differ between commits.
  • build//instructions: -26.1G (-1.30%)

Large changes (1✅)

1 hidden

Small changes (1🟥)

  • 🟥 build/module/Cslib.Computability.Distributed.FLP.Consensus//instructions: +31.4M (+0.38%) (reduced significance based on absolute threshold)

@Garmelon
Garmelon force-pushed the update-bench-suite branch from d42966b to d2756db Compare July 10, 2026 16:32
@Garmelon
Garmelon marked this pull request as ready for review July 10, 2026 16:42
@Garmelon

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Jul 10, 2026

Copy link
Copy Markdown

Benchmark results for d2756db against c0120dd are in. No significant results found. @Garmelon

Warning

These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.

  • Bench repo commit hashes for run main differ between commits.
  • build//instructions: -24.0G (-1.20%)

Small changes (1✅, 1🟥)

  • build//instructions: -24.0G (-1.20%)
  • 🟥 build/module/Cslib.Computability.Distributed.FLP.Consensus//instructions: +8.9M (+0.11%)

and 1 hidden

@Garmelon

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Jul 10, 2026

Copy link
Copy Markdown

Benchmark results for b2c4c87 against c0120dd are in. No significant results found. @Garmelon

Warning

These warnings may indicate that the benchmark results are not directly comparable, for example due to changes in the runner configuration or hardware.

  • Bench repo commit hashes for run main differ between commits.
  • build//instructions: -24.5G (-1.22%)

Small changes (1✅, 1🟥)

  • build//instructions: -24.5G (-1.22%)
  • 🟥 build/module/Cslib.Computability.Distributed.FLP.Consensus//instructions: +16.5M (+0.20%)

and 1 hidden

@chenson2018

Copy link
Copy Markdown
Collaborator

@Garmelon Are you still working on this, or is it okay to merge?

@Garmelon

Copy link
Copy Markdown
Contributor Author

It is ready to merge. Sorry for not making that clearer.

@chenson2018 chenson2018 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all, thank you!

@chenson2018
chenson2018 added this pull request to the merge queue Jul 11, 2026
Merged via the queue into leanprover:main with commit 9d9053c Jul 11, 2026
2 checks passed
@Garmelon
Garmelon deleted the update-bench-suite branch July 13, 2026 14:28
ctchou pushed a commit to ctchou/cslib that referenced this pull request Jul 13, 2026
This tweak brings the bench suite more in line with the other repos. It
should not affect functionality.

Follow-up to leanprover#707.
intgrah pushed a commit to intgrah/cslib that referenced this pull request Jul 14, 2026
This PR refactors the cslib bench suite so it closely resembles
mathlib's again, following leanprover-community/mathlib4#41587.
intgrah pushed a commit to intgrah/cslib that referenced this pull request Jul 14, 2026
This tweak brings the bench suite more in line with the other repos. It
should not affect functionality.

Follow-up to leanprover#707.
fmontesi pushed a commit that referenced this pull request Jul 22, 2026
This PR refactors the cslib bench suite so it closely resembles
mathlib's again, following leanprover-community/mathlib4#41587.
fmontesi pushed a commit that referenced this pull request Jul 22, 2026
This tweak brings the bench suite more in line with the other repos. It
should not affect functionality.

Follow-up to #707.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants