Repository navigation
Don't show '(default: None)' for required arguments without a default - #370
Open
mayuriphad wants to merge 1 commit into
Open
mayuriphad wants to merge 1 commit into
mayuriphad wants to merge 1 commit into
Conversation
SimpleHelpFormatter inherits argparse's ArgumentDefaultsHelpFormatter, which appends '(default: None)' to every option. A required field with no default therefore claimed a default it does not have. Skip the default suffix for required actions whose default is None. Optional arguments are unchanged. Updates test_issue_48, which pinned the old output for two required fields, and adds a regression test. Fixes lebrice#96
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96.
What & Why
\SimpleHelpFormatter\ inherits argparse's \ArgumentDefaultsHelpFormatter, which appends (default: None)\ to each option. A required field with no default showed a default it does not have. Required actions whose default is \None\ now skip that suffix. Optional arguments are unchanged.
Changes
Test