fix: Fix broken GCC 16 build (enforce C11/C++17 compile )#1478
Open
cphlipot wants to merge 3 commits into
Open
fix: Fix broken GCC 16 build (enforce C11/C++17 compile )#1478cphlipot wants to merge 3 commits into
cphlipot wants to merge 3 commits into
Conversation
Contributor
|
Tested this patch and it fixed the compilation problem for me. |
|
Thanks for unblocking the GCC 16 build! |
Currently the project requests the C11 and C++17 feature sets using target_compile_features, however this only gaurentees us a minimum C++ version of C++17, and allows compile to proceed with C++20 (the GCC 16 default) if it is already set. Building Stable-diffusion.cpp with C++20 results in build failures as std::u8string can no longer be assigned to std::string due to C++20 standards changes. Explictly set the required language standard to C++17 in order to ensure we pass/fail the build consistently across compiler toolchains even if compilers by default try to expose a superset of C++17 features. Tested build succeeds on Fedora 44 with GCC 16.
This reverts commit ee89d25bf946c115ab42e7d21918b9879702b2ea.
Contributor
Author
|
Updated the PR. Now the CmakeLists.txt should enforce C11/C++17 at the project level instead of target level, aligning itself with how other projects like GGML do this. this also simplified the change a bit. Also i noticed @leejet just added a CONTRIBUTING.md and PR template, so updated the PR to comply with those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the project requests the C11 and C++17 feature sets using
target_compile_features, however this only gaurentees us a minimum
C++ version of C++17, and allows compile to proceed with C++20
(the GCC 16 default) if it is already set.
Building Stable-diffusion.cpp with C++20 results in build failures
as std::u8string can no longer be assigned to std::string due to
C++20 standards changes.
Explicitly set the required language standard to C++17 in order to
ensure we pass/fail the build consistently across compiler toolchains
even if compilers by default try to expose a superset of C++17
features.
This fix copies the approach used by https://github.com/ggml-org/ggml/blob/master/CMakeLists.txt#L284-L288
A side effect of this change is that is also now enforces the CONTRIBUTING.md's requirement
to use C++17 at the CMake level.
Related Issue / Discussion
#1475
Additional Information
Tested build now succeeds on Fedora 44 with GCC 16 using the
following commands for vulkan build from build.md
Verify GCC 16+ is being used:
then verify build:
Checklist