Don't exit on failure if cert-checker finds bad certs#8866
Open
lenaunderwood22 wants to merge 2 commits into
Open
Don't exit on failure if cert-checker finds bad certs#8866lenaunderwood22 wants to merge 2 commits into
lenaunderwood22 wants to merge 2 commits into
Conversation
jsha
previously approved these changes
Jul 10, 2026
jsha
left a comment
jsha
left a comment
Contributor
There was a problem hiding this comment.
This looks good. You've described separately why this is the desired behavior. Would you mind updating the PR description with that description? Thanks!
Member
|
Because we also run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cert-checker failing when it finds bad certs has undesirable behavior on the deploy side (e.g. job failure due to bad cert discovery leads to unnecessary redeployment of the job and re-firing of associated alerts) and IMO finding bad certs is not a failure of the cert-checker (in fact, it did it's job, woohoo!)