Repository navigation
fix(transcript): drop a trailing dot from the authority name - #34
Merged
Merged
Conversation
The spec fixes the authority preimage as the lowercase TLS server name with no trailing dot, and the profiles pin keccak256 of that form. `api.x.com.` names the same server as `api.x.com` but hashed to an id no profile pins, so every attestation over the absolute form was refused. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
The identity layout read the id with the JSON readers alone, which take
`0`, any number of digits and, quoted, any string. REQ-PLAT-06 holds
the id to `^[1-9][0-9]{0,19}$` at most 2^64 - 1, so the prover now
refuses what the Platform Verifier must refuse, where the reason shows.
The bare-number scan moves onto JsonMember so the digits reach the check.
Assisted-by: Claude Opus 5.5
Signed-off-by: xgreenx <xgreenx9999@gmail.com>
This reverts commit 2890b8a. The id range builders lay out what the prover reveals. Only the libid-tlsn fixture examples and tests call them, and no notary, keeper or bridge path does. The REQ-PLAT-06 gap sits in the on-chain verifier, so the change reshaped a published crate's API without closing it. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
authority_id_ofhashedapi.x.com.to an id no profile pins, though ceremony-common §9 fixes the authority as the lowercase server name with no trailing dot.Changes
crates/libid-transcript/src/attestation.rs:140).a_trailing_dot_names_the_same_authority:api.x.com,api.x.com.andAPI.X.COM.hash toCeremonyProfile.AUTHORITY_X_API,api.x.com..does not.attestation.rsalone.Verified
cargo +nightly-2026-08-10 fmt --all -- --check: clean.cargo +1.97.1 clippy --all-targets --all-features -- -D warnings: clean.cargo +1.97.1 test --all: passes, libid-transcript 70 tests.cast keccak "api.x.com"equals the pinned literal.Not verified / known issues
ObservedSession.authority. The fix reaches production after a libid-rs release and a notary dependency bump.Decision for the owner
🤖 Generated with Claude Code