Require C99 compiler - #81
Merged
Merged
Conversation
Already required for configure builds, now also for CMake builds. Simplifies some code as e.g. lrint and stdint.h are always available. Closes libsndfile#77
Contributor
Author
|
Rebased on master. @erikd Any more issues with this? |
Member
|
Has MSVC caught up to C99 yet? For the longest time (at least 5 years since I last checked) it hadn't. |
Contributor
Author
|
It at least supports all features used (VAM, stdint.h, lrint, ...) You can double-check if you merge #82 which uses VS 2017 on travis. |
erikd
approved these changes
Aug 10, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already required for configure builds, now also for CMake builds.
Simplifies some code as e.g. lrint and stdint.h are always available.
Closes #77
Note: Always links to libm (if found) as required by the C standard when using functions from math.h. If those are inlined the linker will discard anything from libm which isn't used, even everything. So there is no downside. The previous attempt checking IF linking it is required was brittle, because multi-config generators might require it for Debug builds but not Release builds causing compile failures.