Skip to content

fix(responses): promote deferred tools in routed passthrough - #1602

Merged
lidge-jun merged 1 commit into
lidge-jun:devfrom
Eleven-is-cool:agent/promote-passthrough-deferred-tools
Aug 13, 2026
Merged

lidge-jun merged 1 commit into
lidge-jun:devfrom
Eleven-is-cool:agent/promote-passthrough-deferred-tools

Conversation

@Eleven-is-cool

@Eleven-is-cool Eleven-is-cool commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Promote tool definitions returned by client-executed tool_search before forwarding noncanonical Responses passthrough requests.
  • Merge loaded namespace tools into either top-level tools or Responses Lite additional_tools, activate returned deferred declarations without duplicating existing names, and preserve canonical forward behavior.

Verification

  • bun test tests/openai-responses-passthrough.test.ts (68 pass)
  • bun run typecheck
  • bun run privacy:scan
  • git diff --check
  • bun run test was also exercised outside the restricted sandbox; unrelated timing-sensitive shim and WebSocket tests did not complete cleanly, while the focused passthrough suite stayed green.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (No user-facing configuration change.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c82e2b25-933e-4495-bd11-97402158565c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ All CI tests are green on my local testing.
  • ⬜ I pushed my PR to the latest dev commit.
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

@Eleven-is-cool
Eleven-is-cool force-pushed the agent/promote-passthrough-deferred-tools branch from 7bf2f9f to 8934225 Compare August 13, 2026 10:25
@lidge-jun
lidge-jun merged commit b633032 into lidge-jun:dev Aug 13, 2026
4 of 5 checks passed
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants