Skip to content

test(kiro): assert that the bounded completion fallback executes (carry of #3487) - #3602

Merged
lidge-jun merged 1 commit into
devfrom
codex/260905-kiro-fallback-guard
Sep 5, 2026
Merged

test(kiro): assert that the bounded completion fallback executes (carry of #3487)#3602
lidge-jun merged 1 commit into
devfrom
codex/260905-kiro-fallback-guard

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Summary

Carries #3487 to the migrated Kiro test path. The fallback regression now counts its fetch calls, so it fails if the bounded completion fallback stops running even when the calibration estimate stays unchanged.

Verification

  • Seven-line diff inspected at 4b289cd; no production change.
  • No local tests run in this continuation. Final dev Linux CI is the requested batch gate.

Checklist

  • One focused test correction.
  • No documentation or runtime behavior change.
  • No secrets or authentication changes.

Co-authored-by: Ingwannu 186453546+Ingwannu@users.noreply.github.com

Summary by CodeRabbit

  • Tests
    • Updated calibration fallback coverage to verify that exactly one bounded fallback request is made.

@Ingwannu jun
test(kiro): prove the bounded completion fallback runs
4b289cd 
Reimplementation of #3487 at the post-reorg path: the original patch targets
tests/kiro-stream.test.ts, deleted by the #3516/#3518 test-layout reorg, so it
is carried onto tests/providers/kiro/kiro-stream.test.ts instead.

The fallback test asserted only that the calibration estimate did not move,
which stays true if the bounded fallback stopped firing entirely. Counting the
stubbed fetch separates 'did not calibrate' from 'did not run'.

Co-authored-by: Ingwannu <186453546+Ingwannu@users.noreply.github.com>
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 5, 2026 03:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-05T03:40:35.536689Z 4b289cd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun merged commit f8ba644 into dev Sep 5, 2026
5 of 7 checks passed
@lidge-jun
lidge-jun deleted the codex/260905-kiro-fallback-guard branch September 5, 2026 03:38
@coderabbitai

coderabbitai Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: c72cad8a-5997-45fb-abd9-24d743856aaa

📥 Commits

Reviewing files that changed from the base of the PR and between 4504562 and 4b289cd.

📒 Files selected for processing (1)
  • tests/providers/kiro/kiro-stream.test.ts
📝 Walkthrough

Walkthrough

The calibration fallback test now counts fallback fetch invocations and verifies that exactly one fallback request occurs.

Changes

Calibration fallback validation

Layer / File(s) Summary
Fallback call count assertion
tests/providers/kiro/kiro-stream.test.ts		 The fallback fetch mock increments fallbackCalls. The calibration test asserts that the count is exactly one.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/260905-kiro-fallback-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@lidge-jun lidge-jun mentioned this pull request Sep 5, 2026
Closed
3 tasks done
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
@lidge-jun
test(kiro): prove the bounded completion fallback runs (lidge-jun#3602)
29e2394 
Owner-authorized admin squash for the 260905 campaign. Local suite omitted as requested; final dev Linux CI is the batch gate. Original contributor attribution is preserved in the branch commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ingwannu Ingwannu Awaiting requested review from Ingwannu Ingwannu is a code owner

Assignees

No one assigned

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lidge-jun @Ingwannu