Repository navigation
fix(gui): guide native login switching and manual retry - #6581
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (7)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe native profile switch interface now shows translated confirmation steps, error guidance, and conditional result notices. Tests cover confirmation, refresh, retry, and error cases. The guide documents the switch sequence and the meaning of confirmed results. ChangesNative profile switch guidance
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The guidance does not automatically retry a switch or offer an actionable switch while the credential store is unsupported. No actionable merge-blocking issue remains after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
Scoped intake at I independently checked hosted run Keep Draft and complete the repository's head-bound readiness checklist when ready for owner/maintainer review. Please keep #6387 open until its remaining scope is accepted and actually lands; green CI does not close an issue. Final copy/visual/platform acceptance remains with the owner. No new scan, sponsorship waiver, approval, integration or deployment was supplied. |
There was a problem hiding this comment.
Rebase/readiness checkpoint at 7b455346431c8f0f242e61bde7c452b238292cd7, base dev e53c8077e40b6f540bf1e5d5791a55282466bfac.
The head is a normal merge of the earlier b3eab828 source head and current dev. All five PR-owned guidance/doc/test files are byte-identical to b3eab828; the large older-head-relative GUI delta comes from integrated dev, not a new guidance implementation. I did not repeat the earlier author-reported GUI/browser tests or independently certify their geometry/native-login results.
Verification still names b3eab828 and its older successful CI as the source HEAD. Please add this published head/base, preserve those results as historical receipts, and link the completed current-head checks when available. Cross-platform CI 37253418151 and React Doctor 37253418180 are pending; the previous head's green status does not validate the merged tree. Keep Draft, owner UI review and the installed/native acceptance limits separate. This is a source-identity/readiness check only, not approval of the mounted component or authentication behavior; no real account switch, new scan or local test was performed.
Author-response checkpoint — 2026-10-05 02:50 UTC intake: I read comment 5987247586 and the updated current-tree Verification. It now names 7b455346431c8f0f242e61bde7c452b238292cd7 / base e53c8077, labels older receipts historical, and separately reports 2,909 isolated GUI passes, 46 focused passes, typecheck, lint and build. This addresses the description/source-identity request; those are author results, not my executions or UI certification. Current-head React Doctor 37253881075 has succeeded; the initial React run 37253418180 was cancelled, and Cross-platform CI 37253418151 is currently in progress, not passing. Draft is restored. Owner UI review and installed/native acceptance remain separate conditions. No component/geometry security review, new scan, local test, approval or merge was performed.
|
Addressed the source-identity/readiness checkpoint in the description for Current-tree local validation is recorded separately: full isolated GUI suite 2,909 pass, focused checks 46 pass, root typecheck, GUI lint/build and dev-relative whitespace checks pass. These are author checks, not owner UI approval or installed/native acceptance. I restored Draft to respect the review's Keep Draft condition. Current-head Cross-platform CI has now completed successfully: 16 jobs succeeded and 9 were skipped, including success of all four Linux test shards and the final aggregate. React Doctor also passed on this same head. The description records the exact skipped scope; installed/native acceptance and owner UI review remain separate, so Draft is retained. No workflow was cancelled, restarted or dispatched for this update. |
Tighten the confirmation steps and recovery copy so each line names a concrete action: close native Codex on the server computer, select the checkbox, confirm, then reopen. Error copy drops lock and ownership internals while keeping the rule that a missing response is not a rollback, and the retry hint reads as conditional because the same notice covers profile-save failures. The error and result notices use a native-main-notice class instead of inline display styles. All locales, the guide and existing native-main tests are updated.
… styling happy-dom ships no [hidden] display rule, so a hidden div still computes as block once :not([hidden]) stops matching. Assert the stylesheet guard that lets the browser's hidden rule win instead.
|
Maintainer integration (lidge-jun, dev only) — 2026-10-05 bug triage round 2, lane B1.
|
Summary
After a blocked native-login switch the panel showed a generic failure and a diagnostic code, and the close → confirm → check → reopen sequence was buried in one paragraph. This PR gives each step and each failure a concrete next action.
native-main-noticeclass (.notice.native-main-notice:not([hidden]) { display: block; }) instead of inline styles. All 11 locales and the native main profiles guide are updated.Completes the remaining UI-guidance scope of #6387 (the German layout was fixed by #6388). No change to session/request logic, credentials, process inspection, confirmation requirements, management authentication, recovery transactions or Pool selection.
Maintainer refresh (lane B1): merged current
dev(37189ca3) into the branch and tightened the copy after review (removed "home above", "stopped acknowledgement" and lock/ownership internals; made the retry hint conditional because the same notice covers profile-save failures), replaced the inline styles with the class, and updated the guide and existing tests. Original implementation by @luvs01.Verification
No local tests were run, per the repository owner's instruction for this round; test evidence is hosted CI at the exact head.
Static checks run at
4c7031124a08917805cb516e6ed15bee306d318a, all exit 0:bun run typecheck,bun run privacy:scan,bun run structure:check,bun scripts/file-size-ratchet.ts,bun run lint:gui,(cd gui && bun run lint:i18n),(cd gui && bun run build),git diff --check. The native-main catalog has 52 keys in English and in each of ko, de, fr, zh, zh-TW, ru, ja, tr, vi and pt.styles.cssis 2953 lines (cap 2958).Existing tests were updated (no new test files): exact English guidance, step → checkbox → confirm DOM order, retry hint and class for CODEX_BUSY, NATIVE_PROFILE_BUSY, PROFILE_STORAGE_UNSAFE and NETWORK_ERROR, and the notice cascade (the class beats
.notice-warn; the rule keeps its:not([hidden])guard).Rendered with the real
NativeMainProfilesViewand production CSS in a sandboxed Vite harness (temporary HOME/OPENCODEX_HOME/CODEX_HOME, synthetic profiles and paths, no network), captured with headless Chromium; no console errors and no external requests. No real login switch, installed client or proxy was exercised.Exact-head CI: Cross-platform CI 37323315993 completed success on attempt 1 for
4c7031124a08917805cb516e6ed15bee306d318a(pull_request event): changes, gates, all four Linux test shards, storage policy, API usage, docs site build, Docker smoke, keyring (Ubuntu/Windows), npm-global (Ubuntu/Windows) and the finalciaggregate succeeded. The structure gate, standalone privacy job, Windows/macOS matrices, macOS control/widget, setup action, remote helper and desktop shell were skipped by the change filter and are not counted as executed coverage (structure and privacy were run locally above; privacy also runs insidegates). React Doctor and CodeRabbit passed on this head. The branch has no file overlap withdevchanges merged since (#6638, #6626).English, light — confirmation steps, CODEX_BUSY with manual retry, and the last confirmed restart result:
German, dark, keyboard focus on the checkbox:
Korean: another operation running, unsafe storage, lost response · English at 390px
Checklist