Repository navigation
Conversation
Add 60-second absolute and 15-second idle-progress limits for accepted unfinished uploads. Release aggregate admission on expiry and stop both clocks on body completion or the first upstream reply. Keep upstream backpressure distinct from client idleness. Preserve the merged graceful FIN and 30-second TCP linger policies from upstream dev bf57900. Adapt upload regressions from fork PR #724 at a4195a9, with new HTTP/1 admission and early-reply tests.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
Thank you @luvs01 for the careful work and thorough tests here! After review I'm closing this one. To clarify the overlap question first: it does not duplicate #6984 / #7010 (43232a4). That change bounds the post-response discard of an abandoned upload, and this PR bounds the pre-response upload phase. The reasons for closing:
If you've seen a real stall that the upstream timeout doesn't cover, an idle-only bound (no absolute cap) with a reproducer would be very welcome as a fresh PR. Thanks again! |
Summary
Verification
5977aab4c36fbc9af512d05664fc12ccfbbff2fb.dev:3bb7a5612c35c8079f5683a6d408a6907cf98bbe. A clean temporary integration at09daa6a4e1a209b35f21cf688cc204efe5282497retains the identical source delta and passed 168 tests across 11 files with pinned Bun 1.4.3. Coverage includes upload deadlines, linger and listener lifecycle, picker models, native context, GPT-6.1 Sol rows, Meta Muse Wonder, test layout, file-size ratchet and the core/Lab import boundary.bun run typecheck,bun run privacy:scan,bun run structure:checkandgit diff --checkpassed on that integration. The temporary integration is validation evidence; the posted source remains the fixed HEAD above.test:changedruns remain outstanding under the repository's resource exception. Native macOS/Windows application and GUI validation are unavailable in this Linux environment. Exact posted-head upstream CI and independent review remain required; this PR stays in draft.Checklist