Repository navigation
Conversation
Refuse oversized and non-regular managed configuration inputs, apply the same 4 MiB write bound before target mutation, and retain committed or uncertain snapshots. Read small files into initialized size-proportional buffers while preserving growth and overflow probes. Preserve store-owned cleanup for unused snapshots and all current upstream test registrations. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Drain bounded stdout and stderr from generation-race children, identify exits before readiness, and report per-child missing files and import phases. Reap owned children in a finally block when readiness or outcome collection fails. Keep the 10-second readiness and child deadlines and the exact-one-callback generation assertions unchanged. Add real-child regressions for early exit, bounded capture, and cleanup. This records evidence for the Windows startup timeout; it does not claim that timeout is fixed.
Separate oversized-file rejection from final-symlink rejection. Probe file-symlink creation on Windows and mark only that test skipped for EPERM/EACCES; preserve other errors and execute the rejection check when creation succeeds. The oversized assertion already preceded link creation, but an unavailable link privilege failed the combined test. Keep byte-boundary coverage unconditional and record actual symlink skips.
|
Preserve child-startup evidence before classifying the Windows race timeout. The Windows 6/9 failure is at A different upstream Windows run passed the exact case in 1.72s; two other inspected Windows controls passed in 1.16s and 1.47s. Linux candidate and dev controls also pass. These comparisons do not establish an infrastructure-only cause or justify rerunning unchanged CI. A local diagnostic follow-up now continuously captures bounded output tails, records config-import/readiness phases and each child's exit/signal and ready-file state, and reaps created children in Separate local follow-ups for the other observed test boundaries.
These changes remain local; no Windows result for the combined new candidate or resolution of the generation startup cause is claimed. |
Carry the validated two-file fixture correction from a7b9af8. Perform production initialization and its initial launch tick before measuring maintenance, then wait for the actual child PID readiness signal instead of a fixed sleep. Retain the 250 ms maintenance bound, process reaping assertions, and delayed Online readiness coverage. The production tray script and fixture dependencies are byte-identical to the source whose native Windows case passed. Local Linux checks do not execute the native PowerShell paths; new-head Windows CI remains required. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Thank you @luvs01! This landed through #7029 (squash d934632), which carries your two in-scope commits unchanged with your authorship and a Co-authored-by trailer. I left out the two test-hardening commits (generation-child startup diagnostics and the Windows tray probe readiness change) only to keep the PR on one topic. They look useful, so please feel free to open them as a separate PR. Closing this one as superseded. |
…ss (#7038) * test(config): preserve generation child startup diagnostics Drain bounded stdout and stderr from generation-race children, identify exits before readiness, and report per-child missing files and import phases. Reap owned children in a finally block when readiness or outcome collection fails. Keep the 10-second readiness and child deadlines and the exact-one-callback generation assertions unchanged. Add real-child regressions for early exit, bounded capture, and cleanup. This records evidence for a startup timeout; it does not claim that timeout is fixed. Reconstruct the test-only follow-up from #7017 on current dev. Source-commit: 3e76357 Co-authored-by: Epinephrine <27862058+luvs01@users.noreply.github.com> * test(windows): align tray probe readiness with production startup Perform production initialization and its initial launch tick before measuring maintenance, then wait for the actual child PID readiness signal instead of a fixed sleep. Retain the 250 ms maintenance bound, process reaping assertions, and delayed Online readiness coverage. Reconstruct the test-only follow-up from #7017 on current dev. Native Windows validation of this new candidate is still required; prior source-commit CI is not evidence for this candidate. Source-commit: 23b4333 Co-authored-by: Epinephrine <27862058+luvs01@users.noreply.github.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: Epinephrine <27862058+luvs01@users.noreply.github.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: bitkyc08-arch <bitkyc08@gmail.com>
Summary
Verification
23b4333ca39eb18b42d8dfe200820f0f583169ac, based on upstreamdev6da2774369aa32552e318e333902499683d053bc. Normal fast-forward from the previous560e0f4c5f6b7af740c467886fb5f4f9fde2644a; the production source is unchanged by the three follow-ups.bun run typecheck,bun run privacy:scan,bun run structure:check, the repository file-size ratchet and parent-relativegit diff --checkpassed. The Linux tray suite reported 28 passes, but its native PowerShell branches do not execute on Linux; those are not claimed as native lifecycle coverage.0632248daecbcc0c88702292fddf019538fdd6a1passed 570 tests across 20 reader/writer/state/journal/Cline/Aside/client-synchronization and boundary files. Its docs build passed for 569 pages and 79,369 links. Production source, scripts, structure, docs, GUI, skills and dependency-lock inputs are unchanged; the follow-up changes four test/fixture files. The intervening upstream version-only change passed version consistency and its single selected regression; nine unrelated cases were intentionally filtered.test:changedwere not repeated under the repository's resource exception. Native macOS/Windows and GUI/application execution remain unrun locally. Independent review remains outstanding and this PR stays in draft.Checklist