Repository navigation
fix(catalog): preserve uncapped native maximum context windows - #7130
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
# Conflicts: # scripts/test-layout/layout.json # tests/fixtures/test-layout-expected.json
# Conflicts: # scripts/test-layout/layout.json
# Conflicts: # scripts/test-layout/layout.json # tests/fixtures/test-layout-expected.json
|
Maintainer integration into
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
max_context_windowwhen no configured hard limit narrows it: Astra keeps its 872,000 maximum alongside the 272,000 default. Share configured-limit validation and precedence between native accessors and catalog normalization, including preserved native rows without static metadata.07e6aeb41a, which added per-model window support; that invariant stays covered.Closes #7075
Verification
bun run typecheck— passed.bun test tests/codex-integration/catalog-native-max-context.test.ts— reproduced 16 failures before the fix; 26 passed after it.bun test tests/codex-integration/catalog-native-max-context.test.ts tests/codex-integration/native-model-toggle.test.ts tests/codex-integration/codex-catalog.test.ts tests/providers/auto-compact-budget.test.ts— 408 passed, 0 failed. Updated existing assertions that encoded the erroneous maximum; compaction assertions remain unchanged.bun test tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts— 36 passed, 0 failed.bun run structure:check— passed after keeping the catalog doc within its existing budget.bun run privacy:scan— passed.cd docs-site && bun install --frozen-lockfileandbun run build— passed; 577 pages and 81,200 internal links checked.bun run test:changed— attempted but executed no tests: queued for five minutes behind another worktree's user-scoped test lock (reported owner pid 48122), then stopped this lane's waiting command to avoid leaving a latent run. no lock bypass or other lane's processes were touched.Resource exception: the full
bun run testsuite was deliberately not run because bundle-triage lanes share one 16-core machine. Focused regressions cover the changed behavior; broader Ubuntu coverage is left to PR CI. No macOS/Windows workflows dispatched.Independent review round 1 (
2f73663d4):bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --checkpassed.Independent mutation proof: restoring both original source files from
7640a942bmadebun test tests/codex-integration/catalog-native-max-context.test.tsfail 16/26 cases; restoring the fix passed 26/26. Before the selector-normalization fix, the corrected retained-selector integration assertion and new strict-normalization regression failed (2 failures / 48 cases); all four new normalization cases now pass, including unmarked, malformed and explicitly routed negatives.Focused validation covered 621 tests across 16 files with every file passing in its final state. The combined command below passed 620 tests; one temporary review edit to an explicitly capped discovery expectation failed and was reverted. Re-running
bun test tests/claude-integration/claude-models-discovery.test.tspassed all 13 cases. The other 15 files were unchanged after their successful results and were not rerun.bun test tests/codex-integration/catalog-native-max-context.test.ts tests/codex-integration/configured-native-models.test.ts tests/codex-integration/gpt6-native-rows.test.ts tests/codex-integration/discovered-native-models.test.ts tests/codex-integration/gpt61-sol-rows.test.ts tests/codex-integration/codex-catalog-sync-hardening.test.ts tests/codex-integration/codex-convergence-account-selectors.test.ts tests/codex-integration/codex-catalog-restore.test.ts tests/claude-integration/claude-models-discovery.test.ts tests/codex-integration/native-model-toggle.test.ts tests/codex-integration/codex-catalog.test.ts tests/providers/auto-compact-budget.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/lab/core-lab-boundary.test.tstest:changed, as requested for the shared machine. Broader coverage remains with Ubuntu PR CI; no platform workflows were dispatched. Draft state is preserved.Checklist