Skip to content

test(codex): isolate runtime selection fixture - #7457

Closed
Shreyas652 wants to merge 1 commit into
lidge-jun:devfrom
Shreyas652:fix/7403-codex-runtime-test-isolation
Closed

Shreyas652 wants to merge 1 commit into
lidge-jun:devfrom
Shreyas652:fix/7403-codex-runtime-test-isolation

Conversation

@Shreyas652

@Shreyas652 Shreyas652 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Closes #7403.

Summary

  • Make the missing-version persistence regression independent of Codex installations on the test host.
  • Isolate HOME, CODEX_HOME, PATH, installed-runtime enumeration, and the bounded --version probe before seeding the process memo.
  • Keep the existing installed-source controls unchanged. This is a test-only change with no production behavior change.

Verification

  • bun scripts/test.ts --parallel=1 ./tests/codex-integration/codex-runtime.test.ts — 59 passed, 0 failed.
  • bun scripts/test.ts --changed=dev --parallel=1 — 59 passed, 0 failed.
  • bun x tsc --noEmit — passed.
  • bun scripts/privacy-scan.ts — passed.
  • Full suite not run: this is a one-file test-fixture change, and the focused plus changed-graph runs select the same affected test file. Hosted CI remains required.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
    • No user-facing behavior changed; no documentation update is needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.
    • No production, authentication, credential, workflow, release, or dependency surface changed.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • Required local validation passed; commands, results, and any full-suite exception are documented.

  • I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
  • ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

@Ingwannu

Copy link
Copy Markdown
Owner

Scoped review at d796fc2913f2a26aafa63d81b5e7b0aaaabf02d9: the missing-runtime setup is isolated while installed-source controls remain intact. Independently ran bun test tests/codex-integration/codex-runtime.test.ts on Linux/Bun 1.4.3 under fresh homes and hard resource limits: 59 passed, 0 failed. Approved execution of Cross-platform CI and React Doctor. The PR is still Draft with its readiness checklist open; I have not changed that author attestation or marked #7403 fixed on dev.

@lidge-jun

Copy link
Copy Markdown
Owner

Carried in #7552 together with the related flaky-test fixes, keeping your commit as its author and a Co-authored-by trailer in the PR description. Thank you for the clean isolation fix. A maintainer will decide on closing this one.

@lidge-jun

Copy link
Copy Markdown
Owner

Thank you for this work. It has been carried onto current dev in #7552, with your authorship kept as a Co-authored-by trailer, and review continues there. Closing this PR in favour of #7552.

@lidge-jun lidge-jun closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants