Repository navigation
fix(retry): honor upstream no-retry verdict - #7505
Platinum-Scripts wants to merge 1 commit into
Conversation
Signed-off-by: Platinum-Scripts <133908028+Platinum-Scripts@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
Carried onto the current |
Stop fetchWithTransientRetry's same-target transient ladder when the upstream gateway status carries the exact x-should-retry: false verdict, returning the original response with its body intact. Carries #7505. Signed-off-by: Platinum-Scripts <133908028+Platinum-Scripts@users.noreply.github.com> Co-authored-by: Platinum-Scripts <133908028+Platinum-Scripts@users.noreply.github.com>
|
Thank you, @Platinum-Scripts. This change was carried onto current |
Summary
x-should-retry: falseverdict.retryable: falsebody.Verification
bun test tests/lib/upstream-retry.test.ts— 69 pass, 0 fail, 275 assertions.bun run typecheck— pass.bun run structure:check— pass.bun run privacy:scan— pass.bun run test:changed— 44,244 pass, 108 skip, 0 fail, 711,243 assertions across 2,047 files.claude-desktop-remote-hub.test.ts. The exact focused test fails identically on pristineupstream/devatbf4eb120because generated synthetic model aliases are ordered differently after a cold restart.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.