Repository navigation
test(server): isolate agent-task-recovery fixtures (#7613) - #7649
Conversation
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Local CI-equivalent (macOS) at f749269Overall: PROVISIONAL — full-suite coverage pending under the updated verification rule. Host: Git setup: fetch pull head, resolve FETCH_HEAD, confirm detached HEAD, and compute merge-base completed with exit 0; no test counts apply. Head was re-fetched after verification to check for movement. Workflow source: Environment: Suite environment:
Failures and base comparisons: Base scratch setup:
NOT RUN:
Raw command logs and structured results retained on this host in |
Local CI-equivalent (Linux) at f749269Final verdict: PASS (temporary rule; raw base-identical test failures retained). This includes every primary batch selected by all four Linux shards. Host All new suite/base invocations use documented Batch file lists are generated by the exact head’s original planner. Only its script-directory anchors point back to the original location; its test command/deadlines are unchanged. Every previously executed batch file list was checked against the reconstructed manifest. Remaining batches ran serially; any new failure stayed failed and did not suppress later missing batches.
Original CI commands (no reruns):
Remaining primary batches — each command is
Remainder totals: 21767 pass / 0 fail / 79 skip. Combined original + remainder command counts: 55637 pass / 1 fail / 167 skip. Failed checks remain failed; final disposition uses only the explicit BASE-IDENTICAL exception. Failure classification across original and remainder evidence:
Base comparisons (cached once per distinct file/exact failed batch):
Every original non-test gate result is retained in the original-command table above. No source edits, pushes, approvals or merges were performed. Source status: clean ( NOT RUN: Hosted CI and platforms/jobs outside the requested Linux scope Exact manifests and raw logs (retained on the named Linux host):
UTC: 2026-10-24T11:45:56.021210+00:00 |
|
Integration evidence for exact head f749269 (lane L2):
Static merge simulation on current dev af8cd35 (this Mac): dev=af8cd35a0665eace70abe9cc83f4263222bcdf79 base=47316142fe06171a94de02d63f1727dbed4c0382 pr_files= 2 overlap=[]; merge clean; install exit=0; gui install exit=0; tsc exit=0; tsc doctor exit=0; structure:check exit=0; privacy:scan exit=0; layout+ratchet guards exit=0 52 pass 0 fail ; Merged by the triage manager as maintainer integration (MAINTAINERS.md, dev only) under the owner's static-judgment rule while GitHub Actions is degraded; dev push CI will be checked when Actions recovers. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Verification
bun test tests/server/agent-task-recovery.test.tswith pinned Bun 1.4.3: exit 0; 103 pass / 0 fail, including the unchanged Retry-After floor.bun run typecheck: exit 0. Additional strict helper typecheck: exit 0 (tsc --ignoreConfig --noEmit --strict --skipLibCheck --target esnext --module esnext --moduleResolution bundler --resolveJsonModule --esModuleInterop --types bun-types tests/helpers/agent-task-recovery-fixture.ts).bun run privacy:scanandbun run structure:check: exit 0.bun run test:changed: exit 0; 103 pass / 0 fail across the changed test file at head876aa4defa4eb32ddb0fdf442ed689c42a85b4e8.OCX_TEST_RUNNER_BUNpoints to the locally downloaded 1.4.3 binary.connected Desktop uses hub IDs across a cold restart (stored profile=false)attests/claude-integration/claude-desktop-remote-hub.test.ts:249. All 21 serial lanes passed. The run began on the pre-patch base and does not certify the final head. This is not final-head passing evidence. No test was skipped or weakened. A second full local run is disproportionate while concurrent lanes share this host and the first run already takes several minutes; final-head focused/import-connected tests and Ubuntu CI cover this fixture change.876aa4defa4eb32ddb0fdf442ed689c42a85b4e8: PASS, no findings; exact-head Ubuntu CI is queued; all required local validation and the independent review are complete; this PR remains draft while exact-head CI is queued.Checklist