Skip to content

docs(responses): register and document citation replay coverage (carry #7608) - #7865

Merged
lidge-jun merged 1 commit into
devfrom
n5/carry-7608-citation-docs
Oct 28, 2026
Merged

lidge-jun merged 1 commit into
devfrom
n5/carry-7608-citation-docs

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Carries #7608 by @Ingwannu onto current dev. The runtime repair for url_citation titles already landed in #7573, and its regression tests/responses/responses-url-citation-title-repair.test.ts is on dev, but the owning structure doc and the explicit test registration were never merged.

  • Adds structure/transports/response-citations.md (outbound citation repair in src/adapters/openai-responses/request-strips.ts, generated titles in src/bridge/response-json.ts and src/bridge/sse.ts) and its manifest entry; structure/INDEX.md is regenerated.
  • Links it from the checkpoint section of structure/transports/responses.md (same line, no growth).
  • Registers the existing regression in scripts/test-layout/layout.json and tests/fixtures/test-layout-expected.json on existing lines.

The original branch cannot receive maintainer pushes and conflicted with dev in structure/manifest.json, structure/transports/responses.md and the generated index; both sides were kept.

Co-authored-by: Ingwannu 186453546+Ingwannu@users.noreply.github.com

Verification

Bun 1.4.4, Windows:

  • bun scripts/test.ts tests/responses/responses-url-citation-title-repair.test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/ci-workflows/structure-ssot.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts: 98 pass / 0 fail.
  • bun run structure:index and bun run structure:check: pass.
  • NOT RUN locally: full bun run test (documentation and registration only; left to PR CI).

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (none touched).

Carries #7608 onto current dev: adds the response-citations structure
doc, links it from responses.md and registers the existing
url-citation title-repair regression in the test layout.

Co-authored-by: Ingwannu <186453546+Ingwannu@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 4cdcb50 and a7faeba.

Files selected for processing: 6
  • scripts/test-layout/layout.json
  • structure/INDEX.md
  • structure/manifest.json
  • structure/transports/response-citations.md
  • structure/transports/responses.md
  • tests/fixtures/test-layout-expected.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T03:01:25.817193Z a7faeba PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 28, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev. Exact head a7faeba97ab0b86a70fc9bb9a459139739c3591f, no conflict with current dev. Exact-head PR CI: Cross-platform CI 40624138056 (gates, test 1/4-4/4, ci) and enforce-target: success. Documentation and test-registration only; carries #7608 with a Co-authored-by trailer for @Ingwannu.

@lidge-jun
lidge-jun merged commit d67fedd into dev Oct 28, 2026
29 checks passed
@lidge-jun
lidge-jun deleted the n5/carry-7608-citation-docs branch October 28, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant