Skip to content

test(windows): budget hosted fixture phases without weakening contracts - #7946

Merged
lidge-jun merged 2 commits into
devfrom
fix/windows-hosted-fixture-budgets-2
Oct 29, 2026
Merged

lidge-jun merged 2 commits into
devfrom
fix/windows-hosted-fixture-budgets-2

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

This recreates the closed, unmerged #7932 on current dev: its two commits (5ff6025, 1ab00a1), cherry-picked unchanged. The dev lane=all batch 40819570452 failed again on hosted Windows (job 123269463253) in tests/server/management-route-registry.test.ts:149: elapsed 2665ms against the fixed < 2_500 discriminator. This is the same failure #7932 diagnosed in run 40796504652 (2703ms).

Test fixtures only, two files:

  • Management responsiveness (tests/server/management-route-registry.test.ts): the race and the elapsed-time assertion both stay. On Windows the gated metadata child uses INTERNAL_DEADLINE_MS, and the concurrent request must answer within 5/8 of that gate, the same 2500/4000 ratio as before. POSIX keeps its 4s gate and 2.5s bound. Cleanup now releases the gate and awaits planning before deleting the fixture, even when an assertion fails.
  • Native stream diagnostics (tests/claude-integration/claude-native-passthrough.test.ts): the two body-failure fixtures (body stall, byte cap) no longer inherit cfg()'s 250ms header timeout on Windows, so they reach the body path they assert. They also get SERVER_BUDGET_MS as their outer budget. The dedicated header-timeout test keeps 250ms.

No product code, production deadline, shared budget constant, skip or behavioral assertion changes. #7932's description has the full per-run evidence table.

Verification

  • bun test tests/server/management-route-registry.test.ts tests/claude-integration/claude-native-passthrough.test.ts on Windows x64 (OCX_TEST_NO_QUEUE=1): 100 pass / 0 fail / 1 skip.
  • bun run typecheck: exit 0. tests/ci-workflows/file-size-ratchet.test.ts: 9 pass / 0 fail.
  • NOT RUN: hosted Windows and macOS. Those run only in the batched dev check after this lands.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. N/A: test fixtures only.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. N/A: no product code changes.

@lidge-jun lidge-jun added the bug Something isn't working label Oct 29, 2026
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 29, 2026 05:22
@lidge-jun lidge-jun added the bug Something isn't working label Oct 29, 2026
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between f4eef7b and 86a0417.

Files selected for processing: 2
  • tests/claude-integration/claude-native-passthrough.test.ts
  • tests/server/management-route-registry.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T05:23:46.811214Z 86a0417 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@lidge-jun
lidge-jun merged commit 9b78a16 into dev Oct 29, 2026
31 of 33 checks passed
@lidge-jun
lidge-jun deleted the fix/windows-hosted-fixture-budgets-2 branch October 29, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant