Repository navigation
test(windows): budget hosted fixture phases without weakening contracts - #7946
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
Summary
This recreates the closed, unmerged #7932 on current
dev: its two commits (5ff6025, 1ab00a1), cherry-picked unchanged. The devlane=allbatch 40819570452 failed again on hosted Windows (job 123269463253) intests/server/management-route-registry.test.ts:149: elapsed 2665ms against the fixed< 2_500discriminator. This is the same failure #7932 diagnosed in run 40796504652 (2703ms).Test fixtures only, two files:
tests/server/management-route-registry.test.ts): the race and the elapsed-time assertion both stay. On Windows the gated metadata child usesINTERNAL_DEADLINE_MS, and the concurrent request must answer within 5/8 of that gate, the same 2500/4000 ratio as before. POSIX keeps its 4s gate and 2.5s bound. Cleanup now releases the gate and awaits planning before deleting the fixture, even when an assertion fails.tests/claude-integration/claude-native-passthrough.test.ts): the two body-failure fixtures (body stall, byte cap) no longer inheritcfg()'s 250ms header timeout on Windows, so they reach the body path they assert. They also getSERVER_BUDGET_MSas their outer budget. The dedicated header-timeout test keeps 250ms.No product code, production deadline, shared budget constant, skip or behavioral assertion changes. #7932's description has the full per-run evidence table.
Verification
bun test tests/server/management-route-registry.test.ts tests/claude-integration/claude-native-passthrough.test.tson Windows x64 (OCX_TEST_NO_QUEUE=1): 100 pass / 0 fail / 1 skip.bun run typecheck: exit 0.tests/ci-workflows/file-size-ratchet.test.ts: 9 pass / 0 fail.devcheck after this lands.Checklist