Repository navigation
SR phase 2 - #2002
Draft
dry914 wants to merge 35 commits into
Draft
SR phase 2#2002dry914 wants to merge 35 commits into
dry914 wants to merge 35 commits into
Conversation
Feat/lip 38 twg twb
|
Hardhat Unit Tests Coverage SummaryDetailsDiff against masterResults for commit: 6b84406 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
dry914
added
next upgrade
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+86
to
+125
| function getVoteItems() public view override returns (VoteItem[] memory items) { | ||
| SRPhase2UpgradeConfig config = SRPhase2UpgradeConfig(CONFIG); | ||
| address dualGovernance = address(DUAL_GOVERNANCE); | ||
|
|
||
| VoteItem[] memory rawItems = _getVoteItems(); | ||
| CallsScriptBuilder.Context memory scriptBuilder = CallsScriptBuilder.create(); | ||
| for (uint256 i = 0; i < rawItems.length; ++i) { | ||
| scriptBuilder.addCall(rawItems[i].call.to, rawItems[i].call.data); | ||
| } | ||
|
|
||
| items = new VoteItem[](DG_ITEMS_COUNT); | ||
| items[0] = VoteItem({ | ||
| description: "1. Upgrade the SR phase 2 (LIP-38) contracts through the Agent", | ||
| call: _votingCall(AGENT, abi.encodeCall(IForwarder.forward, (scriptBuilder.getResult()))) | ||
| }); | ||
| items[1] = VoteItem({ | ||
| description: "2. Remove the old TriggerableWithdrawalsGateway from the Dual Governance tiebreaker sealable withdrawal blockers", | ||
| call: _votingCall( | ||
| dualGovernance, | ||
| abi.encodeCall( | ||
| IDualGovernanceTiebreaker.removeTiebreakerSealableWithdrawalBlocker, | ||
| (config.OLD_TRIGGERABLE_WITHDRAWALS_GATEWAY()) | ||
| ) | ||
| ) | ||
| }); | ||
| items[2] = VoteItem({ | ||
| description: "3. Add the new TriggerableWithdrawalsGateway to the Dual Governance tiebreaker sealable withdrawal blockers", | ||
| call: _votingCall( | ||
| dualGovernance, | ||
| abi.encodeCall( | ||
| IDualGovernanceTiebreaker.addTiebreakerSealableWithdrawalBlocker, | ||
| (config.NEW_TRIGGERABLE_WITHDRAWALS_GATEWAY()) | ||
| ) | ||
| ) | ||
| }); | ||
| items[3] = VoteItem({ | ||
| description: "4. Call SRPhase2UpgradeTemplate.finishUpgrade", | ||
| call: _forwardCall(AGENT, TEMPLATE, abi.encodeCall(SRPhase2UpgradeTemplate.finishUpgrade, ())) | ||
| }); | ||
| } |
Feat/phase 2 vebo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See LIP-38 for details.