Skip to content

Macaroon stateless - #428

Merged
guggero merged 1 commit into
masterfrom
macaroon-stateless
Nov 5, 2021
Merged

guggero merged 1 commit into
masterfrom
macaroon-stateless

Conversation

@guggero

@guggero guggero commented Nov 4, 2021 •

Copy link
Copy Markdown
Contributor

Replaces #406.

In some cases we don't want the default macaroon file to be created on
disk, so we allow passing in a boolean that toggles the macaroon
creation.

This is for the LiT stateless integrated mode.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

@guggero
guggero force-pushed the macaroon-stateless branch from 7affd6b to 4a2cd24 Compare November 4, 2021 13:01
In some cases we don't want the default macaroon file to be created on
disk, so we allow passing in a boolean that toggles the macaroon
creation.

@bhandras bhandras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carlaKC carlaKC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@guggero
guggero merged commit 7c4d8f6 into master Nov 5, 2021
@guggero
guggero deleted the macaroon-stateless branch June 20, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants