docs: add Ethereum to supported-chain table and capabilities list - #777
Merged
Conversation
Ethereum L1 (ETHEREUM_WALLET) is fully supported in the API and present in the OpenAPI schemas, the generated bundle, and the Grid Visualizer, but was absent from every hand-written docs page. Adds Ethereum L1 coverage to the pages that enumerate supported wallets or chains, matching each page's existing pattern: - snippets/external-accounts.mdx: Ethereum L1 wallet creation example in the Cryptocurrency tab - snippets/internal-accounts.mdx: "Ethereum Stablecoin Funding" accordion alongside the other per-chain funding examples - snippets/sending/cross-currency.mdx: Ethereum row in the supported blockchains table - platform-overview/introduction/platform-capabilities.mdx: Ethereum in the self-custody wallet list Asset support (USDC and USDT) is taken from openapi/components/schemas/common/PaymentEthereumWalletInfo.yaml. Docs-only; no OpenAPI source or generated bundle changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MMnjJ8yWJsui7jLqqrDrL4
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Greptile SummaryDocuments Ethereum L1 wallet support across Grid’s developer documentation.
Confidence Score: 5/5The documentation-only PR appears safe to merge with no actionable defects identified. The new Ethereum account and funding documentation agrees with the repository’s wallet schemas, supported USDC/USDT asset combinations, and established Mintlify patterns.
|
| Filename | Overview |
|---|---|
| mintlify/platform-overview/introduction/platform-capabilities.mdx | Adds Ethereum to the self-custody network list consistently with the surrounding network terminology. |
| mintlify/snippets/external-accounts.mdx | Adds a schema-consistent Ethereum L1 external-account example and an appropriate wrong-network warning. |
| mintlify/snippets/internal-accounts.mdx | Documents Ethereum funding instructions using the supported ETHEREUM_WALLET account type and USDC/USDT assets. |
| mintlify/snippets/sending/cross-currency.mdx | Adds Ethereum’s supported stablecoins to the existing blockchain funding matrix. |
Reviews (1): Last reviewed commit: "docs: document Ethereum L1 external acco..." | Re-trigger Greptile
Keeps the two changes that complete existing lists and drops the two that added Ethereum-specific example content. The blockchains table already had Base, Tron, Polygon, Lightning and Spark rows, and the self-custody wallet list already read "Spark, Solana, Tron, Base, Polygon, etc." - Ethereum was simply missing from both. Adding it makes those enumerations correct. The external-accounts and internal-accounts pages are a different case. Neither documents any wallet type except Spark, so an Ethereum-only example there reads as a curated list of the two supported chains rather than as two entries from a set of seven. Base, Polygon, Plasma, Solana and Tron are all equally undocumented; they should be written up together or not at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MMnjJ8yWJsui7jLqqrDrL4
shreyav
changed the title
AaryamanBhute
approved these changes
Jul 30, 2026
AaryamanBhute
approved these changes
Jul 30, 2026
shreyav
added a commit
that referenced
this pull request
Aug 4, 2026
## Summary `PaymentEthereumWalletInfo.yaml` declares `enum: [USDC, USDT]`, but `crypto.ts` listed `ETHEREUM_WALLET` only under USDT. USDC-on-Ethereum is supported by the API and simply could not be selected in the visualizer, so that flow could not be built or code-generated. One line. Ethereum is the only chain carrying both assets — Base and Polygon are USDC-only per their own `Payment<Chain>WalletInfo.yaml` enums — so this is the single missing entry, not the first of a batch. | Chain | Schema enum | In `crypto.ts` before | |---|---|---| | Ethereum | `USDC`, `USDT` | USDT only ❌ | | Base | `USDC` | USDC ✅ | | Polygon | `USDC` | USDC ✅ | ##⚠️ Missing network icon — please read `NetworkDropdown` renders `/networks/${network.toLowerCase()}.svg` with no error handling, and **`public/networks/ethereum.svg` does not exist**. The new row will render without an icon. This gap is pre-existing, not introduced here — `tron.svg` and `plasma.svg` are missing too, so USDT's dropdown already shows three iconless rows. But USDC's dropdown currently has all three of its icons (`solana`, `polygon`, `base`), so this change does put the first broken one there. I did not add the asset: an Ethereum mark is brand artwork, and inventing one that doesn't match the existing set is worse than leaving the gap visible. Someone should drop in `ethereum.svg` — and `tron.svg` / `plasma.svg` while they're at it, since those are already broken today. If the missing icon is a blocker, holding this until the asset lands is reasonable. The data being wrong is the more serious problem, so I'd merge and follow up. ## Verification - Strict typecheck of `crypto.ts` — clean - Cross-checked all three EVM chains against their `Payment<Chain>WalletInfo.yaml` enums, not just Ethereum - **Not verified:** no build or render check — `npm ci` fails here because `@central-icons-react` requires `CENTRAL_LICENSE_KEY`. The Vercel preview is the real check; worth confirming the USDC dropdown now offers Ethereum and seeing how the iconless row actually looks. ## Context Found while triaging the stale docs-sync PRs. This is the one genuinely-unlanded, non-documentation item from #288, whose other changes are already on `main` (`ETHEREUM_WALLET` in `account-types.ts`, the `businessType: FINTECH` → `FINANCE_AND_INSURANCE` fix) or superseded (currency entries via #791, the supported-chain table via #777). --- _Generated by [Claude Code](https://claude.ai/code/session_01MMnjJ8yWJsui7jLqqrDrL4)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Ethereum to the two places that already enumerate supported chains and were missing it. Docs-only, 2 files, +2/-1.
mintlify/snippets/sending/cross-currency.mdxEthereum | USDC, USDTrow in the supported blockchains tablemintlify/platform-overview/introduction/platform-capabilities.mdxBoth generated bundles (
openapi.yaml,mintlify/openapi.yaml) are byte-identical tomain.Why only these two
An earlier revision of this PR also added an Ethereum L1 example to
snippets/external-accounts.mdxand an Ethereum funding accordion tosnippets/internal-accounts.mdx. Both were dropped in bbfeb06.The two remaining changes fix incomplete enumerations. The blockchains table already had Base, Tron, Polygon, Lightning and Spark rows; the capabilities list already read "Spark, Solana, Tron, Base, Polygon, etc." Ethereum was supported and simply absent from both, so adding it makes them correct.
The two dropped changes were a different case. Neither of those pages documents any wallet type other than Spark —
BASE_WALLET,POLYGON_WALLET,PLASMA_WALLET,SOLANA_WALLETandTRON_WALLETappear nowhere inexternal-accounts.mdx. Adding an Ethereum-only example there would read as a curated list of the two chains Grid supports, rather than two entries from a set of seven. That's arguably worse than the current silence.Follow-up this leaves open
external-accounts.mdxdocuments 1 of 7 wallet external-account types. Base, Polygon, Plasma, Solana, Tron and Ethereum are all undocumented there, and none of their schemas carryx-internal,deprecated, or a beta marker — the omission looks incidental, not deliberate. They should be written up as one set, with per-chain asset support derived from eachPayment<Chain>WalletInfo.yamlenum rather than assumed (they differ: Ethereum is[USDC, USDT], Base and Polygon are USDC-only).Separately, and outside the scope of a docs PR:
components/grid-visualizer/src/data/crypto.tslistsETHEREUM_WALLETonly under USDT and omits it from USDC, which contradictsPaymentEthereumWalletInfo.yamldeclaringenum: [USDC, USDT].Verification
@mdx-js/mdxcompiler bundled withmintlify@4.2.284;mintlify broken-linksreports no broken links in the touched files.make lintfails onmainas well —npx spectral linterrors withspectral: not foundbecause npm resolves a stubspectral@0.0.0instead of@stoplight/spectral-cli. Pre-existing and reproducible on a clean checkout; distinct from the separately-brokenlint-markdown. The step that does run,@redocly/cli lint, passes with 50 pre-existing warnings.Supersedes the documentation portion of #288, whose Grid Visualizer changes already landed on
mainvia later syncs.