Repository navigation
Make Input id as required (in TS typings) #51
Description
Description
The id for an Input should probably be marked as required by it's TS typings. If not, its label will not have labelFor set.
Expected behavior
Spit out a TS error when id is not present.
Actual behavior
Not having an id is not flagged as an error, while the docs state that id should be set.
Steps to reproduce the problem
- Create an
Inputand don't set theidprop - No TS errors/warnings
Specifications
- Affected component(s): Input
- Versions: latest
Activity
xdrdak commentedon Nov 25, 2019
Hmm, technically speaking, you don't actually ever need to add an id to an Input. Just like a native HTML input element will not trigger any warnings for lack of the id prop.
Probably the documentation should be worded better. It should perhaps read:
Inputs should have a unique ID prop whenever the label prop is being used.
The behaviour of
Inputis to automatically inject a pre-formatted label should the label prop be applied.