Repository navigation
Description
Is your code refactoring request related to a problem?
flaky-test-detection.yml (42 lines) is a small standalone workflow that runs Jest tests multiple times to detect non-deterministic (flaky) tests. Running it as a separate workflow adds scheduling overhead for minimal standalone benefit — it can be absorbed cleanly into checks.yml as a conditional job.
Part of epic #1227 — Workflows Consolidation Initiative. Net: −1 workflow.
Describe the Refactoring / Review Task
Add the flaky detection logic to checks.yml as a schedule-gated job:
# Add to checks.yml triggers:
on:
schedule:
- cron: "0 */12 * * 1-5" # Every 12h Mon-Fri
# Add job:
flaky-detection:
name: Flaky Test Detection
if: github.event_name == 'schedule'
runs-on: ubuntu-latest
strategy:
matrix:
run_number: [1, 2, 3]
steps:
# verbatim from flaky-test-detection.ymlDecision gate: If checks.yml exceeds 400 lines after absorption, keep flaky-test-detection.yml standalone and document the decision in PHASE_4_PLANNING.md.
Use Case
- Reduces total workflow file count without complexity trade-off (42 lines is small)
- All test-related CI logic centralised in
checks.yml
Alternatives Considered
- Keep standalone: Acceptable if
checks.ymlis already large; decision criteria is documented above - Delete entirely: Not recommended — flaky test detection is a valuable quality gate
Additional Context
Dependency: Independent of other Phase 4 sub-phases. Can start immediately after Phase 3.3.
See: .github/projects/active/workflows-consolidation-2026-q3/PHASE_4_PLANNING.md
Definition of Ready (DoR)
- Refactoring goals and scope defined
- Code area(s) and impact listed
- Dependencies mapped (independent)
- Current
checks.ymlline count checked - Estimate added
Definition of Done (DoD)
- Flaky detection logic added to
checks.yml(or decision to keep standalone documented) -
flaky-test-detection.ymldeleted (if absorbed) - Schedule trigger added/verified in
checks.yml - Flaky detection runs correctly on next scheduled trigger
- Code meets org coding standards
- PR uses correct branch prefix (
refactor/)
Metadata
Metadata
Assignees
Labels
Type
Fields
Priority
Activity
linear-code commentedon Jul 29, 2026
LS-1961
github-actions commentedon Jul 29, 2026
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow.
ashleyshaw commentedon Aug 7, 2026
✅ Phase 4 planning complete: PR #1631 merged to develop
All Phase 4 planning documents, specifications, and coordination timelines are now available in the merged PR. This issue is ready for execution per the CONSOLIDATED_ACTION_PLAN_2026_08_07.md timeline.
See merged PR #1631 for:
Status: Ready for execution. Refer to coordination deadlines in action plan.
github-actions commentedon Sep 3, 2026
Unchecked DoD items found. Please complete all checklist items before closing this issue.
To close this issue:
To force close this issue without completing DoD:
meta:force-closelabelFor more information on Definition of Done standards, see the issue template guide: https://github.com/lightspeedwp/.github/issues/new/choose
github-actions commentedon Sep 3, 2026
Milestone Allocation
github-actions commentedon Sep 3, 2026
✅ Issue checklists finalised after closure.
github-actions commentedon Sep 8, 2026
This issue has labels that are not in the canonical taxonomy:
migrate:status:readymigrate:type:refactorpriority:lowstatus:ready-for-developmentValid Canonical Labels
Please use labels with a prefix from the canonical taxonomy:
type:bug,type:feature,type:task,type:documentation, etc.status:needs-triage,status:in-progress,status:done, etc.priority:critical,priority:high,priority:normal,priority:lowarea:ci,area:docs,area:labels,area:security, etc.meta:needs-changelog,meta:duplicate,meta:blocked, etc.For the complete list, see .github/labels.yml.