Skip to content

Phase 4.4: Absorb flaky-test-detection.yml into checks.yml #1409

Description

@ashleyshaw

Is your code refactoring request related to a problem?

flaky-test-detection.yml (42 lines) is a small standalone workflow that runs Jest tests multiple times to detect non-deterministic (flaky) tests. Running it as a separate workflow adds scheduling overhead for minimal standalone benefit — it can be absorbed cleanly into checks.yml as a conditional job.

Part of epic #1227 — Workflows Consolidation Initiative. Net: −1 workflow.

Describe the Refactoring / Review Task

Add the flaky detection logic to checks.yml as a schedule-gated job:

# Add to checks.yml triggers:
on:
  schedule:
    - cron: "0 */12 * * 1-5"  # Every 12h Mon-Fri

# Add job:
flaky-detection:
  name: Flaky Test Detection
  if: github.event_name == 'schedule'
  runs-on: ubuntu-latest
  strategy:
    matrix:
      run_number: [1, 2, 3]
  steps:
    # verbatim from flaky-test-detection.yml

Decision gate: If checks.yml exceeds 400 lines after absorption, keep flaky-test-detection.yml standalone and document the decision in PHASE_4_PLANNING.md.

Use Case

  • Reduces total workflow file count without complexity trade-off (42 lines is small)
  • All test-related CI logic centralised in checks.yml

Alternatives Considered

  • Keep standalone: Acceptable if checks.yml is already large; decision criteria is documented above
  • Delete entirely: Not recommended — flaky test detection is a valuable quality gate

Additional Context

Dependency: Independent of other Phase 4 sub-phases. Can start immediately after Phase 3.3.

See: .github/projects/active/workflows-consolidation-2026-q3/PHASE_4_PLANNING.md


Definition of Ready (DoR)

  • Refactoring goals and scope defined
  • Code area(s) and impact listed
  • Dependencies mapped (independent)
  • Current checks.yml line count checked
  • Estimate added

Definition of Done (DoD)

  • Flaky detection logic added to checks.yml (or decision to keep standalone documented)
  • flaky-test-detection.yml deleted (if absorbed)
  • Schedule trigger added/verified in checks.yml
  • Flaky detection runs correctly on next scheduled trigger
  • Code meets org coding standards
  • PR uses correct branch prefix (refactor/)

Activity

  1. linear-code commented on Jul 29, 2026

    @linear-code
  2. github-actions commented on Jul 29, 2026

    @github-actions
    Contributor

    ⏱️ Aging and SLA annotation

    • Age: 8 day(s)
    • SLA state: SLA risk
    • Thresholds: warn at 7 days, breach at 14 days
    • Last updated: 2026-08-07T14:35:43.897Z

    Maintained by project-meta-sync workflow.

  3. added theissue type on Aug 7, 2026
  4. added this to the v1.0 milestone on Aug 7, 2026
  5. self-assigned this
    on Aug 7, 2026
  6. ashleyshaw commented on Aug 7, 2026

    @ashleyshaw
    MemberAuthor

    ✅ Phase 4 planning complete: PR #1631 merged to develop

    All Phase 4 planning documents, specifications, and coordination timelines are now available in the merged PR. This issue is ready for execution per the CONSOLIDATED_ACTION_PLAN_2026_08_07.md timeline.

    See merged PR #1631 for:

    • OPENSPEC_WORKFLOW_CONSOLIDATION.md (formal specification)
    • CONSOLIDATED_ACTION_PLAN_2026_08_07.md (execution timeline & blockers)
    • GITHUB_ISSUES_PHASE_4_TEMPLATES.md (implementation steps)
    • Detailed risk mitigation and testing protocols

    Status: Ready for execution. Refer to coordination deadlines in action plan.

  7. modified the milestones: v1.0, v1.1 on Aug 29, 2026
  8. github-actions commented on Sep 3, 2026

    @github-actions
    Contributor

    ⚠️ This issue was closed but the Definition of Done (DoD) is not complete.

    Unchecked DoD items found. Please complete all checklist items before closing this issue.

    To close this issue:

    • ✅ Complete all DoD checklist items and check them off
    • 🔁 Close the issue again

    To force close this issue without completing DoD:

    • Add the meta:force-close label
    • The system will then allow closure

    For more information on Definition of Done standards, see the issue template guide: https://github.com/lightspeedwp/.github/issues/new/choose

  9. github-actions commented on Sep 3, 2026

    @github-actions
    Contributor

    Milestone Allocation

    
    
  10. github-actions commented on Sep 3, 2026

    @github-actions
    Contributor

    ✅ Issue checklists finalised after closure.

  11. github-actions commented on Sep 8, 2026

    @github-actions
    Contributor

    ⚠️ Bare Labels Detected

    This issue has labels that are not in the canonical taxonomy:

    • migrate:status:ready
    • migrate:type:refactor
    • priority:low
    • status:ready-for-development

    Valid Canonical Labels

    Please use labels with a prefix from the canonical taxonomy:

    • Type: type:bug, type:feature, type:task, type:documentation, etc.
    • Status: status:needs-triage, status:in-progress, status:done, etc.
    • Priority: priority:critical, priority:high, priority:normal, priority:low
    • Area: area:ci, area:docs, area:labels, area:security, etc.
    • Meta: meta:needs-changelog, meta:duplicate, meta:blocked, etc.

    For the complete list, see .github/labels.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

Fields

Priority

None yet

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions