Repository navigation
Description
Summary
A rebase on feat/playwright-testing-agent-updates (PR #1392, since merged) went wrong. Two things need recovering and one invariant is weaker than it should be.
What was not lost. The agent work itself is safe. #1392 merged into develop, so its six commits are ancestors of it — which is why the PR then displayed almost no diff, since develop...branch is empty for work already in the base. A file-by-file comparison across all 11 differing files confirms develop's agent folder is healthy; the colleague's edits were improvements (portability-aware persistence in the SKILL, a strengthened accessibility rule, five 404ing README badges removed).
What needs recovering:
.github/reports/audits/changelog-keepachangelog-audit-2026-07-29.mdwas destroyed — cut from 117 lines to 22, leaving only frontmatter and a footer with the entire body gone. It survives in commitaea71a0f.- A CI fix exists in no shared location —
233b1b21,fix(ci): support cross-repo issue references in validate-pr-template, is absent fromdevelopand from the remote branch.hasIssueReferencematches only bare same-repo#123, so PR bodies using the standardowner/repo#123form or full GitHub URLs are wrongly flagged as missing a linked issue.
What can be improved while here: the content-parity invariant added in #1392 declares only a five-type prefix of the requirement-type taxonomy, so drift in the remaining three types goes undetected.
Proposed Solution
Branch from develop (already healthy) and apply three deltas. Deliberately not replaying the old branch — it sits behind develop and applying it would mean 71 insertions against 3842 deletions.
- Restore the audit report from
aea71a0f. Restore from the commit, not a working tree — local copies are damaged too. - Cherry-pick
233b1b21before it is lost. - Extend
consistency.jsonfrom five types to all eight. This requires unifying how the three files phrase the list: the five-type prefix is currently the maximal common substring, because they differ in slash-vs-word forms and an inconsistent trailing "or". Unify oncore-prompt.md's wording — the word form is already the house standard (3 of 4 occurrences) and the slash form appears in exactly one line, so this introduces no internal inconsistency.
Two things must not be taken:
- Anything from the old remote branch
eb4c0184. Besides being behinddevelop, it removes the test"a symlink pointing outside is rejected after resolution", which exists to prove the path-traversal oracle stays closed against symlinks. - Local commit
14ae0dff, which extends the taxonomy string but deletes a"files": [line, leavingconsistency.jsoninvalid JSON.
Acceptance Criteria
- Audit report restored to 117 lines with its body intact
-
233b1b21recovered onto a shared branch -
consistency.jsondeclares all eight requirement types and is valid JSON - The three files phrase the taxonomy identically, with no internal inconsistency introduced
- Parity check passes, and fails when drift is introduced in either the original five-type range or the newly covered three
- The symlink-containment test is present
- Diff against
developcontains only these changes — no deletions of newer work - All acceptance criteria met
- Documentation/changelog updated
- Tests added/updated
- PR uses correct branch prefix (
feat/) - Labels/types match org standards
Designs / References
aea71a0f— holds the intact audit report233b1b21— the local-only CI fixeb4c0184— old remote branch; not a recovery source14ae0dff— the commit that invalidated the JSON- feat(playwright-testing-agent): performance routing, a11y/SEO/console gates, and scope-exclusion discipline #1392 — the merged PR this follows
Dependencies
None blocking. Independent of #1394 (checksums policy), #1395 (schema paths) and #1398 (DoD checklist gate).
Testing Approach
The parity hook is its own oracle, so verification is empirical rather than by inspection:
node hooks/multi-provider-consistency-checker/index.js agents/playwright-testing-agentmust pass- Then must fail against a throwaway copy with drift introduced in each range —
performance ruleremoved fromAGENT.md(original prefix) andintegration ruleremoved from the SKILL (newly covered) npx jest hooks/and thetemplate-helperssuitenpm run validate:agent-hooks,validate:changelog, markdownlintgit diff --stat origin/develop..HEADto confirm nothing newer was deleted
Use a cp -R throwaway copy for the drift test, never git checkout to undo — that discards unrelated uncommitted work.
Additional Context
Worth a separate look: how a merge silently gutted a committed file. That is the failure mode that could recur unnoticed, and it is not addressed here.
Also outstanding from #1392's review: the 127 newer CHANGELOG entries have no PR titles, and validate:changelog is not wired into CI (checks.yml runs npm run test, which excludes it), so changelog quality will keep drifting.
Definition of Ready (DoR)
- Problem statement and outcome defined
- Acceptance criteria written
- Designs/specs/references attached — the relevant commit SHAs
- Dependencies mapped
- Estimate added
- Stakeholders/approvers listed
- Milestone/iteration assigned (if applicable)
Definition of Done (DoD)
- All acceptance criteria met
- Tests added/updated; CI green — tests added;
Testing/Validationremain red from the pre-existing schema-path bug (fix(validation): schema paths resolve outside the repo — test:js red on develop, blocking all pushes, PR checks and releases #1395) - Accessibility: WCAG 2.2 AA verified — N/A, no user-facing surface
- Security: the symlink-containment test is verified present, so the path-traversal protection is not silently dropped
- Performance: no measurable regression
- Docs/changelog updated
- Feature toggles/rollout considered — N/A
- QA verified/UAT approved
- Release notes prepared; monitoring/alerts set
🤖 Generated with Claude Code
Metadata
Metadata
Assignees
Type
Fields
Priority
Activity
linear-code commentedon Jul 30, 2026
LS-1979
docs(changelog): point entries at PR #1422
github-actions commentedon Jul 30, 2026
⏱️ Aging and SLA annotation
Maintained by project-meta-sync workflow.
fix: address CodeRabbit review comments — add issue links and clarify…
fix(playwright-testing-agent): recover audit report and CI fix lost i…
github-actions commentedon Aug 4, 2026
✅ Issue checklists finalised after closure.