Skip to content

[Phase 4.1–4.2] GitHub Actions workflow and testing #1758

Closed

Description

@ashleyshaw

Component: Validation Script Unit Tests

Parent Issue: #1755

Objective: Write comprehensive unit tests for branch name validation script

Status: ✅ COMPLETED (Phase 1.1, 2026-08-22)
Deliverable: PR #2302 — Unified validators and agent branch guidance
Test Results: 38/38 tests passing ✅


Summary of Completed Work

This issue was completed as part of Phase 1.1 (Unified validators) of the branch naming enforcement initiative. All tests validate the strict {type}/{scope}-{short-title} pattern across the unified .cjs validator.

Test Coverage:

  • ✅ Valid branch names with all 31 allowed prefixes
  • ✅ Invalid uppercase, underscores, special characters
  • ✅ Valid kebab-case scope and title segments
  • ✅ Edge cases (single-character segments, multiple segments, boundary conditions)
  • ✅ Forbidden prefixes (claude/, copilot/, openai/)
  • ✅ All validators (.js, .cjs) unified to strict pattern

Test Suite Location: .github/scripts/validation/validate-branch-name.test.cjs

Acceptance Criteria:

  • ✅ Tests cover all 31 allowed types
  • ✅ Tests validate kebab-case rules
  • ✅ Tests reject invalid patterns
  • ✅ All tests passing
  • ✅ Test coverage >90%

Effort: 3 hours

Related: #1755, PR #2302

Definition of Ready (DoR)

  • Clear problem statement and expected outcome
  • Acceptance criteria defined
  • Related issues/dependencies identified
  • Required resources/approvals listed

Definition of Done (DoD)

Activity

  1. linear-code commented on Aug 11, 2026

    @linear-code
  2. github-actions commented on Aug 11, 2026

    @github-actions
    Contributor

    ✅ Template check passed after update. Thanks for fixing the issue body.

  3. github-actions commented on Aug 11, 2026

    @github-actions
    Contributor

    ⏱️ Aging and SLA annotation

    • Age: 1 day(s)
    • SLA state: Within SLA
    • Thresholds: warn at 7 days, breach at 14 days
    • Last updated: 2026-08-12T22:40:29.552Z

    Maintained by project-meta-sync workflow.

  4. github-actions commented on Aug 20, 2026

    @github-actions
    Contributor

    ✅ Issue checklists finalised after closure.

  5. github-actions commented on Aug 20, 2026

    @github-actions
    Contributor

    Milestone Allocation

    
    
  6. self-assigned this
    on Sep 8, 2026
  7. github-actions commented on Sep 8, 2026

    @github-actions
    Contributor

    ⚠️ Bare Labels Detected

    This issue has labels that are not in the canonical taxonomy:

    • migrate:area:ci
    • migrate:priority:important
    • migrate:type:task

    Valid Canonical Labels

    Please use labels with a prefix from the canonical taxonomy:

    • Type: type:bug, type:feature, type:task, type:documentation, etc.
    • Status: status:needs-triage, status:in-progress, status:done, etc.
    • Priority: priority:critical, priority:high, priority:normal, priority:low
    • Area: area:ci, area:docs, area:labels, area:security, etc.
    • Meta: meta:needs-changelog, meta:duplicate, meta:blocked, etc.

    For the complete list, see .github/labels.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions