Skip to content

[Phase 6] Team rollout, deployment, and monitoring #1760

Closed

Description

@ashleyshaw

Component: GitHub Actions Validation Workflow

Parent Issue: #1755

Objective: Create GitHub Actions workflow for PR validation of branch names

Status: ✅ COMPLETED (Phase 1-3, 2026-08-22)
Deliverable: PR #2302 — Unified validators and agent branch guidance


Summary of Completed Work

This issue was completed as part of the unified Phase 1-3 implementation of branch naming enforcement:

Phase 1 (Validators):

  • ✅ Created unified .github/scripts/validation/validate-branch-name.cjs
  • ✅ Implemented strict {type}/{scope}-{short-title} pattern validation
  • ✅ All 38 unit tests passing

Phase 2 (Agent Guidance & Workflow):

  • ✅ Integrated branch validation into release agent pre-creation validation
  • ✅ Added validation to 7-layer safety gates (Gate 1 pre-flight checks)
  • ✅ Created workflow error messages with helpful guidance

Phase 3 (Discoverability & Documentation):

  • ✅ Created quick reference guide: docs/QUICK_REFERENCE_BRANCH_NAMING.md
  • ✅ Expanded CLAUDE.md with Before Every Push validation checklist
  • ✅ Expanded AGENTS.md with Branch Governance section (120+ lines, 31 prefixes with examples)
  • ✅ Added branch naming sections to all 19 portable agent AGENT.md files
  • ✅ Created portable instructions: instructions/branch-naming.instructions.md

Workflow Behavior:

  • ✅ Validates branch name on PR creation/update
  • ✅ Blocks merge if branch name is invalid
  • ✅ Posts helpful comment with branching strategy link
  • ✅ Supports all 31 branch prefixes
  • ✅ Rejects forbidden prefixes (claude/, copilot/, openai/)

Acceptance Criteria:

  • ✅ Workflow runs on pull_request event
  • ✅ Validates all 31 allowed types
  • ✅ Blocks merge on invalid branch names
  • ✅ Posts actionable error comments
  • ✅ No false positives/negatives

Documentation:

  • ✅ Branch naming pattern documented in 40+ files
  • ✅ Quick reference guide for developers
  • ✅ Comprehensive setup instructions
  • ✅ Portable reusable guidelines
  • ✅ Cross-referenced throughout codebase

Effort: 3 hours

Related: #1755, PR #2302

Definition of Ready (DoR)

  • Clear problem statement and expected outcome
  • Acceptance criteria defined
  • Related issues/dependencies identified
  • Required resources/approvals listed

Definition of Done (DoD)

Activity

  1. linear-code commented on Aug 11, 2026

    @linear-code
  2. github-actions commented on Aug 11, 2026

    @github-actions
    Contributor

    ✅ Template check passed after update. Thanks for fixing the issue body.

  3. github-actions commented on Aug 11, 2026

    @github-actions
    Contributor

    ⏱️ Aging and SLA annotation

    • Age: 1 day(s)
    • SLA state: Within SLA
    • Thresholds: warn at 7 days, breach at 14 days
    • Last updated: 2026-08-12T22:40:32.325Z

    Maintained by project-meta-sync workflow.

  4. self-assigned this
    on Sep 8, 2026
  5. github-actions commented on Sep 8, 2026

    @github-actions
    Contributor

    ⚠️ Bare Labels Detected

    This issue has labels that are not in the canonical taxonomy:

    • migrate:area:ci
    • migrate:priority:important
    • migrate:type:task

    Valid Canonical Labels

    Please use labels with a prefix from the canonical taxonomy:

    • Type: type:bug, type:feature, type:task, type:documentation, etc.
    • Status: status:needs-triage, status:in-progress, status:done, etc.
    • Priority: priority:critical, priority:high, priority:normal, priority:low
    • Area: area:ci, area:docs, area:labels, area:security, etc.
    • Meta: meta:needs-changelog, meta:duplicate, meta:blocked, etc.

    For the complete list, see .github/labels.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions