You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Design decisions in .github/specs/016-changelog-agent-quality/ raised by CodeRabbit on #3434. They need an owner decision before code changes.
CLI contract (contracts/cli-interface.md) does not match the shipped validator (.github/validation/changelog/): required path, --output-format, csv, --strict, --max-entries, exit codes. Implement an adapter or document the existing interface.
REST interface (contracts/rest-api-interface.md): define path confinement for changelog_path and merge targets.
Data model: line numbers used as immutable IDs; use a stable hash and treat line number as location.
Status update: a coderabbitai[bot] commit (334c1d1, 2026-09-23 05:50 UTC) on #3434 rewrote the spec 016 contracts and docs ("align changelog specifications with the shipped CLI, locking protocol and repository path boundaries"): contracts/cli-interface.md, contracts/rest-api-interface.md, data-model.md, plan.md, quickstart.md, research.md, spec.md, plus registry-schema.json and a schema validator for T064.
These are design decisions written by a bot. They now sit in #3434 and need an owner read before they are treated as agreed. Please review each checklist item above against that commit and tick the ones you accept.
REST path confinement for changelog_path and server-resolved merge targets.
Data model: stable hash/UUID IDs; line number is mutable location.
plan.md is concrete (no template markers).
Skill model: SKILL.md frontmatter across research, spec, data model and quickstart.
Lock files: owner metadata, lease, stale recovery.
Merge blocks until validation completes (reader/writer protocol, FR-011).
Package validation centralised in PackageJsonValidator.
Registry validation against contracts/registry-schema.json; phase fails on errors.
Open: REST request body: must changelog_path and changelog_content be mutually exclusive (CodeRabbit: oneOf, exactly one), or is changelog_path always required with changelog_content as an optional inline override? The text currently says path is required and content is optional.
Last item resolved in b29c26b on #3434 (decided 2026-09-23): changelog_path is always required and confined; changelog_content is an optional inline body that is validated instead of the file on disk; the validate endpoint never writes, and merge operates only on its own confined changelog_path. All items are now done; this issue closes when #3434 merges.
Activity
linear-code commentedon Sep 23, 2026
LS-4235
eleshar commentedon Sep 23, 2026
Status update: a
coderabbitai[bot]commit (334c1d1, 2026-09-23 05:50 UTC) on #3434 rewrote the spec 016 contracts and docs ("align changelog specifications with the shipped CLI, locking protocol and repository path boundaries"):contracts/cli-interface.md,contracts/rest-api-interface.md,data-model.md,plan.md,quickstart.md,research.md,spec.md, plusregistry-schema.jsonand a schema validator for T064.These are design decisions written by a bot. They now sit in #3434 and need an owner read before they are treated as agreed. Please review each checklist item above against that commit and tick the ones you accept.
eleshar commentedon Sep 23, 2026
Status after 447ed24 on #3434, rechecked against the branch:
validate.js --helpoptions, defaults, exit codes,GITHUB_TOKENfallback).changelog_pathand server-resolved merge targets.plan.mdis concrete (no template markers).SKILL.mdfrontmatter across research, spec, data model and quickstart.PackageJsonValidator.contracts/registry-schema.json; phase fails on errors.changelog_pathandchangelog_contentbe mutually exclusive (CodeRabbit:oneOf, exactly one), or ischangelog_pathalways required withchangelog_contentas an optional inline override? The text currently says path is required and content is optional.docs: define changelog_path and changelog_content in the REST contract (
eleshar commentedon Sep 23, 2026
Last item resolved in b29c26b on #3434 (decided 2026-09-23):
changelog_pathis always required and confined;changelog_contentis an optional inline body that is validated instead of the file on disk; the validate endpoint never writes, and merge operates only on its own confinedchangelog_path. All items are now done; this issue closes when #3434 merges.docs(specs): sync 014 and 016 with the agreed #3434 head (b29c26b)
docs: fix the MD022 failure the specification lint caught (#3500)
docs: specs - land CI remediation, changelog agent and agent consolid…
refactor: changelog-agent - establish quality framework and spec 015 …
[-]task: resolve spec 016 changelog-agent design findings[/-][+]docs: changelog-agent - Document specification decisions[/+]