Skip to content

chore(ci): remove unused composite actions, clear shellcheck debt and pin example workflows #3478

Closed

Description

@eleshar

Problem

Loose ends in GitHub Actions left after #3477:

  • Unused composite actions: .github/actions/aggregate-tests and .github/actions/validate-check are referenced by no active workflow.
  • Shellcheck debt: CI lints at --severity=error, so 43 info/style findings pass: SC2086 unquoted $GITHUB_OUTPUT and variables (36), SC2129 (5), SC2012 (1) and SC2162 (1). They are spread across branch-name-validation, changelog-unified, documentation, pr-template-routing and the metrics aggregator.
  • Examples pinned to tags: .github/examples/workflow-consumption-wordpress-{plugin,theme}.yml use @vN tags. Consumers copy these files, so they should show full-SHA pins like the live workflows.

Change

  • Delete the two unused composite actions, or wire them in if a planned workflow needs them. Check [Epic] Workflow Consolidation Initiative 2026-Q4 #2896 first.
  • Fix the findings, then raise SHELLCHECK_OPTS in workflow-lint.yml to --severity=style so they cannot return.
  • Pin the example workflows to SHAs with version comments.

Acceptance

  • actionlint with default shellcheck severity reports 0 findings on active workflows.
  • Semgrep p/github-actions reports 0 github-actions-mutable-action-tag findings outside .github/workflows/archived/.

Relates to #3474, #3477, #2896

Activity

  1. linear-code commented on Sep 23, 2026

    @linear-code
  2. eleshar commented on Sep 25, 2026

    @eleshar
    ContributorAuthor

    Post-close note from a GitHub Actions audit of origin/develop (43d468623b): the shellcheck and example-pinning parts of this issue are done, but one item in the Change list is not.

    This issue asked:

    • Delete the two unused composite actions, or wire them in if a planned workflow needs them.

    #3483 closed this issue but only fixed shellcheck debt and the consumption examples. Both composites are still on develop:

    • .github/actions/aggregate-tests/action.yml — 0 callers
    • .github/actions/validate-check/action.yml — 0 callers

    collect-metrics and apply-labels are used by labeling-unified.yml and are unaffected.

    Reopened in scope as #3570, together with the related inert workflow test harness in .github/tests/. Closing this as completed without either action is what let the dead code survive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions