You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: mermaid - remaining accessibility validator findings after #3491 #3526
validate-mermaid-accessibility.js reports 8 of 150 diagrams in the files #3491 touches as not accessible (run 2026-09-24 on fix/mermaid-acc-placement-3490). #3491 fixes the two YAML-frontmatter cases. The rest are validator false positives or deliberate examples, and need a decision rather than a blanket accTitle:
.github/reports/accessibility/MERMAID_ACCESSIBILITY_AUDIT_2026-08-19.md diagrams 1–3: one-line fragments (accTitle: …, accDescr: …, %%{init}%%) fenced as mermaid. They are syntax examples, not diagrams; fence them as text.
Same file, diagram 4: a deliberate "Before" example without accessibility attributes. Needs a validator opt-out marker, or a text fence.
.github/reports/mermaid/diagram-validation-2025-12-11.md diagram 1 (indented example in a list): add accTitle/accDescr, or treat it as an example.
skills/web-design-reviewer/SKILL.md diagram 2 (block-beta): Mermaid rejects accTitle here. The validator should require a Markdown text alternative above the fence instead (CodeRabbit raised the same on ci(docs): gate diagrams on the Mermaid parser (#3492) #3494 for validate-mermaid-accessibility.js).
Correctly open — and the pull request that claimed to close it never reached develop
The GitHub API reports #3537 as MERGED at 2026-09-25T04:38:49Z with Closes #3526 in its body. That is misleading. #3537's base branch was ci/mermaid-parser-gate-3492, not develop, and its merge commit c58d75389 is not an ancestor of develop and not an ancestor of main. It exists only on that leftover stack branch. So the work it did is on a dead branch and none of it is in the repository.
block-beta still at line 164 with no accessibility attributes
5
PHASE_2_2_TEST_RESULTS.md diagram 2 (graph)
2 mermaid fences still present
The last commit touching files 1–3 on develop is cdbce6ba39 (#3491). #3537 never contributed.
What this needs
Re-do the five items against develop, one commit at a time, without depending on #3494. The block-beta case (item 4) is the one that needs a decision rather than a mechanical fix, and the validator opt-out marker this issue describes is still the right shape for it.
Keeping this issue open is correct. No closure proposed.
Verified on develop at 5ca4c1d (#3705). validate-mermaid-accessibility.js reports 152 of 152 diagrams accessible, 0 non-compliant. The five items: (1) audit diagrams 1 to 3 are now text fences; (2) the Before example is a text fence; (3) diagram-validation-2025-12-11.md diagram 1 carries accTitle and accDescr; (4) the validator now requires a Markdown text alternative above mindmap, sankey-beta and block-beta fences and rejects accTitle/accDescr on them (confirmed with a mermaid 12.0.0 parse), and web-design-reviewer SKILL.md has its alternative; (5) PHASE_2_2_TEST_RESULTS.md holds its two graphs inside a markdown code block as a documented test fixture, not as rendered diagrams, and .github/projects is outside the validator scope. The earlier claim that #3537 closed this never reached develop; this one did.
Activity
linear-code commentedon Sep 24, 2026
LS-4262
fix(docs): drop Mermaid frontmatter the accessibility validator rejec…
docs: changelog entry for remaining Mermaid accessibility fixes (#3526)
fix: docs - repair 123 broken Mermaid diagrams and the fixer that bro…
docs: mermaid - resolve remaining accessibility findings (#3526) (#3537)
eleshar commentedon Sep 30, 2026
Correctly open — and the pull request that claimed to close it never reached
developThe GitHub API reports #3537 as
MERGEDat 2026-09-25T04:38:49Z withCloses #3526in its body. That is misleading. #3537's base branch wasci/mermaid-parser-gate-3492, notdevelop, and its merge commitc58d75389is not an ancestor ofdevelopand not an ancestor ofmain. It exists only on that leftover stack branch. So the work it did is on a dead branch and none of it is in the repository.Two further consequences:
mermaid-accessibility-rules.cjs) introduced there". ci(docs): gate diagrams on the Mermaid parser (#3492) #3494 was closed UNMERGED. That file is absent fromdevelop. So the orphaned branch depends on code that was never merged either — the stack is unrecoverable as it stands and the work has to be redone againstdevelop, not rebased.developbases, but those are fine: both share merge commit642cced9d, which is ondevelop. docs: mermaid - resolve remaining accessibility findings (#3526) #3537 is the only orphan of the three.All five findings are still live on
develop@1a1021eea8developMERMAID_ACCESSIBILITY_AUDIT_2026-08-19.mddiagrams 1–3, syntax fragments fenced asmermaidmermaid— fences at lines 30, 53, 63mermaid— fence at 169, 177diagram-validation-2025-12-11.mddiagram 1accTitleoraccDescranywhere in the fileskills/web-design-reviewer/SKILL.mddiagram 2 (block-beta)block-betastill at line 164 with no accessibility attributesPHASE_2_2_TEST_RESULTS.mddiagram 2 (graph)mermaidfences still presentThe last commit touching files 1–3 on
developiscdbce6ba39(#3491). #3537 never contributed.What this needs
Re-do the five items against
develop, one commit at a time, without depending on #3494. Theblock-betacase (item 4) is the one that needs a decision rather than a mechanical fix, and the validator opt-out marker this issue describes is still the right shape for it.Keeping this issue open is correct. No closure proposed.
docs(changelog): shorten the #3526 entry to the 250 character limit
fix(docs): resolve the remaining Mermaid accessibility findings (#3526)…
eleshar commentedon Oct 4, 2026
Verified on develop at 5ca4c1d (#3705). validate-mermaid-accessibility.js reports 152 of 152 diagrams accessible, 0 non-compliant. The five items: (1) audit diagrams 1 to 3 are now text fences; (2) the Before example is a text fence; (3) diagram-validation-2025-12-11.md diagram 1 carries accTitle and accDescr; (4) the validator now requires a Markdown text alternative above mindmap, sankey-beta and block-beta fences and rejects accTitle/accDescr on them (confirmed with a mermaid 12.0.0 parse), and web-design-reviewer SKILL.md has its alternative; (5) PHASE_2_2_TEST_RESULTS.md holds its two graphs inside a markdown code block as a documented test fixture, not as rendered diagrams, and .github/projects is outside the validator scope. The earlier claim that #3537 closed this never reached develop; this one did.