Repository navigation
fix: FEEDBACK_RESPONSE.md is a single shared root path, so concurrent PRs overwrite each other's AI feedback tracking #3618
Description
Flagged by CodeRabbit as Major during #3604 and #3524's AI Feedback Validation work: the ai-feedback-validation check requires AI review feedback to be tracked in FEEDBACK_RESPONSE.md with a status per item, but the file lives at a single shared repo-root path. A second PR needing a response overwrites the first PR's record - confirmed in practice on both #3604 and #3524, where the file at HEAD held a stale record from an unrelated already-merged PR (#3500) before being corrected.
Fix
Move to a per-PR path (for example FEEDBACK_RESPONSE.md generated per-PR under a scoped location, or embedded in the PR description/comment instead of a tracked file), so concurrent PRs cannot clobber each other's tracking. This changes validation behaviour for every PR using the ai-feedback-validation workflow, so needs a considered design rather than a quick patch.
Reference
Raised in #3604 and #3524's review passes; deferred there pending this dedicated issue.
Activity
linear-code commentedon Sep 28, 2026
GIT-2404
Link the two approved tracking issues into the feedback record
Merge branch 'develop' into config/claude-cloud-environment
Merge branch 'develop' into config/claude-cloud-environment
chore: shared Claude Code cloud environment and branch-name guard (#3524
Merge branch 'develop' into aiops/qodo-pr-agent-integration
eleshar commentedon Sep 30, 2026
Still live on
develop@1a1021eea8FEEDBACK_RESPONSE.mdis a single file at the repository root ondevelop— one path, shared by every pull request that needs one. No per-pull-request directory exists.This issue is the mechanism behind two collisions the repository has already recorded: #3524 and #3604 both hit it on their
developmerges, and #3688 records that it is "now reproducible from a develop merge rather than only from concurrent work".Worth deciding alongside the fix: the collision is only harmful because the file is a fixed path. A per-pull-request location under
.github/keyed on the PR number removes the collision without needing a merge strategy or a lock, and it also fixes the reverse case — a staleFEEDBACK_RESPONSE.mdfrom a merged pull request lingering ondevelopafter the fact.