Skip to content

dependency: git-hooks - Replace Husky while preserving validation #3887

Open

Description

@ashleyshaw

Dependency Update Summary

Replace Husky with the Lefthook version selected by the research/specification phase in lightspeedwp/.github, preserving existing Git-hook validation behaviour.

Linked Stories/Tasks/PRs/Epic

Parent: https://linear.app/lightspeedwp/issue/GIT-2670
Depends on the research/specification deliverable; no native blocker link proposed.
Installation child: #3892

Milestones & Timeline

After reviewed research and specification; before migration parity validation. No dates supplied.

Maintenance summary

Implement pre-commit and pre-push configuration using existing validation commands. Dependency installation, prepare/install setup and installation-health checks belong to the separate installation child. Coordinate activation so existing validation remains operational.

Impact assessment

Preserve lint-staged commands, exclusions and partial-staging behaviour. Preserve the existing branch validator, argument/stdin forwarding and validation of every pushed local branch ref. Do not introduce a second branch-type list or change merge policy.

Test scope

Exercise staged-file checks and pre-push multi-ref handling. Add focused tests for new executable scripts according to repository instructions. Installation, reinstall and installation-health verification belong to the installation child.

Steps / Checklist

  • Confirm the reviewed Lefthook version and migration plan
  • Coordinate with the installation child before replacement-hook activation
  • Register pre-commit and pre-push using existing validation commands
  • Preserve staged-file and multi-ref pre-push behaviour
  • Demonstrate parity and rollback without weakening CI

Acceptance Criteria

  • Task completed and documented
  • Documentation/changelog updated if needed
  • PR uses correct branch prefix (deps/)
  • PR description updated with relevant details
  • Changelog entry prepared for PR (if applicable)
  • Labels/types match org standards
  • Staged checks retain existing exclusions and partial-staging behaviour
  • Pre-push retains argument/stdin handling and multi-ref branch validation
  • Replacement-hook parity and coordinated rollback are verified

Additional Context

Repository: https://github.com/lightspeedwp/.github
Baseline: 65a013b.
Affected existing paths include package.json, package-lock.json, .husky/pre-commit, .husky/pre-push, .lintstagedrc.cjs, lib/hooks/pre-push and scripts/check-git-hooks.mjs. Final new configuration paths require the reviewed plan. Organisation-wide rollout and locked governance edits are excluded.


Definition of Ready (DoR)

  • Task/goal described and scoped
  • Steps/checklist listed
  • Acceptance criteria listed
  • Estimate added (if applicable)

Definition of Done (DoD)

  • Issue is fixed and tested
  • Task completed and documented
  • Documentation/changelog updated if needed
  • PR uses correct branch prefix (deps/)
  • PR uses the correct PR template based on type:dependency PR label or linked issue type or linked issue type:dependency label
  • Branch deleted after merge
  • Linked issue(s) updated with latest status and closed after merge,
  • The related epic should not be closed, instead updated with a comment to reflect the closed issue

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

Medium

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions