Skip to content

test: git-hooks - Verify migration parity, installation and rollback #3889

Open

Description

@ashleyshaw

Testing / Coverage Summary

Verify the Lefthook migration preserves Git-hook semantics and that the agent pilot provides the documented feedback without weakening existing CI.

Linked Stories/Tasks/PRs/Epic

Parent: https://linear.app/lightspeedwp/issue/GIT-2670
Follows Git-hook migration and the supported agent pilot. No native blocker links proposed.

Milestones & Timeline

Validation phase before final documentation and maintainer handoff. No dates supplied.

Action

  • Action Type: ☐ Create ☐ Refactor (select one)
  • Target File: Not yet specified; confirm during migration specification.

Proposed Test Content

Cover partial staging and unstaged-edit preservation, exclusions, filenames with spaces, Windows path handling, multiple pushed branch refs, deletions, tags, empty-stdin fallback, argument forwarding, installation with lifecycle scripts disabled, reinstall, hook-health reporting and rollback.

For each supported pilot agent, exercise successful and failing validation responses. Record unsupported environments and any blocked checks rather than claiming complete coverage.

Scope & Applicability

Repository: https://github.com/lightspeedwp/.github
Baseline: 65a013b.
Use repository test conventions and existing lib/hooks/tests/pre-push.test.js as relevant evidence. Exact new test paths and create/refactor decisions remain unresolved until the migration plan is reviewed. Do not change CI or merge policy merely to satisfy tests.

Acceptance Criteria

  • Test covers all required scenarios and edge cases
  • Test is properly structured and follows conventions
  • Change is documented in the project change log
  • Test has been run and passes as expected
  • Changelog entry prepared for PR if user-facing
  • PR uses correct branch prefix (test/)
  • PR description updated with relevant details
  • Changelog entry prepared for PR (if applicable)
  • Labels/types match org standards
  • Parity matrix records evidence for each required scenario
  • Installation and rollback demonstrated without losing staged or unstaged work
  • Agent validation feedback matches the documented supported-agent contracts

Definition of Ready (DoR)

  • Purpose, scope, and audience defined
  • Target file and action type specified
  • Acceptance criteria listed
  • Estimate added (if applicable)

Definition of Done (DoD)

  • All acceptance criteria met and verified
  • Changelog entry prepared for PR
  • Test passes all required scenarios and environments
  • Documentation updated (if needed)
  • PR uses correct branch prefix (test/)
  • Branch deleted after merge
  • Linked issue(s) updated with latest status and closed after merge,
  • The related epic should not be closed, instead updated with a comment to reflect the closed issue

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

Medium

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions