[PHASE 2] Enhance Reviewer File Analysis (High-Risk Categories) #604

Problem

Reviewer only detects src/ and code files. Misses high-risk changes like configuration, workflows, security files, and database migrations.

Acceptance Criteria

• Categorizes files by risk level: critical, high, medium, low
• Identifies high-risk categories:
  • Configuration: .github/, package*.json, composer.json, .env*, config/, \.github/
  • Workflows: .github/workflows/*
  • Security: SECURITY.md, LICENSE, security-related code
  • Database: migrations, schema files
  • Lock files: package-lock.json, composer.lock (with major version indicators)
• Summary reports: "X critical, Y high-risk, Z medium-risk, W low-risk files"
• Reviewer comment includes breakdown by category
• Tests verify categorization logic

Implementation Plan

1. Add File Categorizer

function categorizeFile(filename) {
  // Returns: { category, riskLevel }
  // category: 'configuration'|'workflow'|'security'|'database'|'source'|'test'|'docs'|'other'
  // riskLevel: 'critical'|'high'|'medium'|'low'
}

2. Define Risk Categories

CRITICAL Risk:

• .github/workflows/*.yml (CI/CD changes)
• Files containing secrets/API keys

HIGH Risk:

• package.json, yarn.lock, pnpm-lock.yaml
• composer.json, composer.lock
• .env* files
• Database migrations, schema files
• GitHub Actions config (.github/settings.yml, etc.)

MEDIUM Risk:

• src/**/*.js|ts|php|py (source code)
• __tests__/**, test/** (tests)
• docs/** (documentation)

LOW Risk:

• Examples, samples, configs
• Comments, formatting
• Non-code changes

3. Update Reviewer Summary

Change from:

**Files changed:** ${files.length}

To:

**Files changed:** ${files.length}
- 🔴 Critical: ${critical.length}
- 🟠 High: ${high.length}
- 🟡 Medium: ${medium.length}
- 🟢 Low: ${low.length}

4. Add Tests

• Test categorization for each risk level
• Test edge cases (hidden files, symlinks)
• Test summary generation

Test Cases

const files = [
  { filename: '.github/workflows/test.yml', expectedRisk: 'critical' },
  { filename: 'package.json', expectedRisk: 'high' },
  { filename: 'src/index.js', expectedRisk: 'medium' },
  { filename: 'README.md', expectedRisk: 'low' },
];

Effort Estimate

Small (1-2 hours)

Priority

🟡 MEDIUM - Improves analysis quality

Dependencies

• Requires: Phase 1 completed ([[PHASE 1] Fix Module System Inconsistency (CommonJS vs ES6) #599-602])

Related Issues

• Related: Issue 2.4 (blocker detection)
• Reference: ai/improvement-plan-planner-reviewer.md (Issue 2.2)

References

• scripts/agents/reviewer.agent.js (lines 64-65)
• ai/audit-planner-reviewer-agents.md (Section 2.2)