Skip to content

test: test-coverage-implementation - Cover linting agent behaviour #935

New issue
New issue
Open
Test Coverage
#953
Open
test: test-coverage-implementation - Cover linting agent behaviour#935
Test Coverage
#953
Assignees
elesharashleyshaw
Labels
area:testingpriority:criticalstatus:needs-triagetype:test
Milestone
v1.4

Description

@ashleyshaw
ashleyshaw
opened on Jun 8, 2026

Testing / Coverage Summary

Reconcile and complete Phase 3 linting-agent coverage against current develop. The existing test is a smoke test and the lint runner is a stub; the checked completion criteria and merged PR #953 do not verify the requested behaviour in current code.

Linked Stories/Tasks/PRs/Epic

Milestones & Timeline

  • Phase 3 of the test-coverage programme; currently assigned to GitHub milestone v1.4.
  • Confirm scope and the current baseline before setting a completion target.

Action

  • Reconcile the programme plan and child specification, then implement and test the agreed linting-agent behaviour.
  • Target: linting-agent test and runner.

Proposed Test Content

  • Agree which parsing, rule-selection, reporting, failure, boundary and integration scenarios belong to this phase, and identify behaviour the runner must implement first.
  • Replace smoke-only coverage with assertions for the agreed scenarios.
  • Run the relevant tests and lint checks; record current file-level coverage and remaining gaps.

Scope & Applicability

Unit and integration-style coverage for the linting agent, subject to the agreed behaviour and test boundary. Audience: maintainers, developers and QA.

Acceptance Criteria

  • The differing Phase 3 plans and any runner dependencies are reconciled.
  • The test suite verifies agreed parsing, rule-selection and reporting behaviour rather than module existence alone.
  • Agreed failure modes, boundary cases and applicable integration scenarios are covered.
  • Current coverage results and remaining gaps are recorded.
  • Relevant tests and lint checks pass with current evidence.
  • Applicable project changelog and PR documentation are updated.

Definition of Ready (DoR)

  • Purpose, scope, audience and runner dependencies agreed.
  • Target files and acceptance criteria confirmed against current code.

Definition of Done (DoD)

  • Agreed acceptance criteria verified against current code.
  • Required tests and lint checks pass, with coverage evidence recorded.
  • Applicable documentation, changelog and review requirements met.

Prior delivery and current gap

PR #953 merged earlier work, recorded in the programme run log. The current test and runner do not establish present completion. The issue register also records this phase as closed despite the live issue being open; reconcile that project record separately.

Activity

  1. ashleyshaw
    added
    migrate:priority:criticalProduction/launch-blocking
    migrate:status:needs-reviewAwaiting code review
    migrate:type:testTesting/coverage
    migrate:area:testingTesting and QA
    area:qualityQuality validation and QA controls
    on Jun 8, 2026

  2. linear-code commented on Jun 8, 2026

    @linear-code
    linear-codeBot
    on Jun 8, 2026 – with Linear Code

    LS-998

    LS-1112

  3. ashleyshaw
    closed this as completedin #953on Jun 8, 2026

  4. github-actions commented on Jun 8, 2026

    @github-actions
    github-actionsBot
    on Jun 8, 2026 – with GitHub Actions
    Contributor

    ✅ Issue checklists finalised after closure.

  5. ashleyshaw
    reopened this on Jun 19, 2026
  6. ashleyshaw
    added this to the v1.4 milestone on Jul 22, 2026
  7. ashleyshaw
    self-assigned this
    on Aug 4, 2026

  8. ashleyshaw commented on Aug 5, 2026

    @ashleyshaw
    ashleyshaw
    on Aug 5, 2026
    MemberAuthor

    Review Assessment - Phase 3: Linting Agent Coverage

    ✅ Linting validation phase - critical priority

    Strengths:

    • Comprehensive test scope (15 tasks covering parse, rules, output, error cases)
    • Edge cases and invalid config explicitly handled
    • Coverage targets linting determinism
    • Proper test file structure planned

    Assessment:

    Linting is a critical early gate in CI pipelines. This phase's coverage ensures reliable lint parsing and reporting.

    Blockers/Dependencies:

    Status: Blocked on Phase 2. Ready to start once Phase 2 is merged.

  9. ashleyshaw
    removed
    migrate:status:needs-reviewAwaiting code review
    on Aug 5, 2026
  10. lightspeed-project-automation
    added the
    Security
    issue type on Sep 7, 2026
  11. linear-code
    added
    priority:critical
    type:test
    area:testing
    on Sep 8, 2026

  12. github-actions commented on Sep 8, 2026

    @github-actions
    github-actionsBot
    on Sep 8, 2026 – with GitHub Actions
    Contributor

    ⚠️ Bare Labels Detected

    This issue has labels that are not in the canonical taxonomy:

    • migrate:priority:critical
    • migrate:type:test
    • migrate:area:testing
    • area:quality

    Valid Canonical Labels

    Please use labels with a prefix from the canonical taxonomy:

    • Type: type:bug, type:feature, type:task, type:documentation, etc.
    • Status: status:needs-triage, status:in-progress, status:done, etc.
    • Priority: priority:critical, priority:high, priority:normal, priority:low
    • Area: area:ci, area:docs, area:labels, area:security, etc.
    • Meta: meta:needs-changelog, meta:duplicate, meta:blocked, etc.

    For the complete list, see .github/labels.yml.

  13. eleshar commented on Sep 23, 2026

    @eleshar
    eleshar
    on Sep 23, 2026
    Contributor

    Closing as stale: no linked open PR and no activity since 2026-08-05, and it belongs to a plan that predates the current agents and skills consolidation (#3464). Reopen if it is still needed.

  14. eleshar
    closed this as not plannedon Sep 23, 2026

  15. eleshar commented on Sep 23, 2026

    @eleshar
    eleshar
    on Sep 23, 2026
    Contributor

    Reopening: this is planned work that has not started, not work that is superseded. It should not have been closed in the #3464 sweep. Sorry for the noise.

  16. eleshar
    reopened this on Sep 23, 2026
  17. github-actions
    added
    status:needs-triage
    and removed
    migrate:priority:criticalProduction/launch-blocking
    migrate:type:testTesting/coverage
    migrate:area:testingTesting and QA
    area:qualityQuality validation and QA controls
    on Sep 23, 2026
  18. ashleyshaw
    changed the title [-][PHASE 3] Linting Agent Coverage[/-] [+]test: test-coverage-implementation - Cover linting agent behaviour[/+] on Sep 25, 2026
  19. ashleyshaw
    changed the issue type from
    Security
    to
    Test Coverage
    on Sep 25, 2026
  20. ashleyshaw
    assigned
    eleshar
    on Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:testingpriority:criticalstatus:needs-triagetype:test

Type

Test Coverage

Fields

Priority

None yet

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions